fix: use collection expressions for IDE0305 compliance

Replace .ToList() with collection expressions ([.. collection]) when
assigning to List<T> properties in ManageUserNotificationsViewModel
to satisfy IDE0305 code analysis enforced in Release builds.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Controllers/UserController.cs

@@ -392,21 +392,21 @@ public async Task<IActionResult> ManageNotifications(Guid id, CancellationToken
             {
                 UserProfileId = userProfile.UserProfileId,
                 DisplayName = userProfile.DisplayName ?? "Unknown",
-                NotificationTypes = (typesResponse.Result?.Data?.Items ?? []).Select(t => new NotificationTypeEntry
+                NotificationTypes = [.. (typesResponse.Result?.Data?.Items ?? []).Select(t => new NotificationTypeEntry
                 {
                     NotificationTypeId = Guid.TryParse(t.NotificationTypeId, out var tid) ? tid : Guid.Empty,
                     Name = t.DisplayName,
                     Description = t.Description,
                     SupportsEmail = t.SupportsEmail,
                     SupportsInApp = t.SupportsInSite
-                }).ToList(),
-                Preferences = (prefsResponse.Result?.Data?.Items ?? []).Select(p => new NotificationPreferenceEntry
+                })],
+                Preferences = [.. (prefsResponse.Result?.Data?.Items ?? []).Select(p => new NotificationPreferenceEntry
                 {
                     NotificationTypeId = Guid.TryParse(p.NotificationTypeId, out var pid) ? pid : Guid.Empty,
                     EmailEnabled = p.EmailEnabled,
                     InAppEnabled = p.InSiteEnabled
-                }).ToList(),
-                Notifications = (notificationsResponse.Result?.Data?.Items ?? []).Select(n => new NotificationEntry
+                })],
+                Notifications = [.. (notificationsResponse.Result?.Data?.Items ?? []).Select(n => new NotificationEntry
                 {
                     NotificationId = n.NotificationId,
                     Title = n.Title,
@@ -415,7 +415,7 @@ public async Task<IActionResult> ManageNotifications(Guid id, CancellationToken
                     SentAt = n.CreatedAt,
                     IsRead = n.IsRead,
                     EmailSent = n.EmailSent
-                }).ToList()
+                })]
             };
 
             return View(vm);