feat: Add aliases support for chat commands and update related tests and views

Author: frasermolyneux

src/XtremeIdiots.Portal.Web.Tests/Controllers/GameServersControllerTests.cs

@@ -213,6 +213,9 @@ public void PopulateConfigFromNamespace_ChatCommandsNamespace_MapsServerOverride
         Assert.Equal("tag-fu", fu.RequiredTags);
         Assert.Single(fu.Messages);
         Assert.Equal("server-fu-{name}", fu.Messages[0].Message);
+
+        var commands = model.ChatCommands.Commands.Single(x => x.Name == "commands");
+        Assert.Equal(["!help"], commands.Aliases);
     }
 
     [Fact]

src/XtremeIdiots.Portal.Web.Tests/Controllers/GlobalSettingsControllerTests.cs

@@ -9,9 +9,9 @@
 using MX.Api.Abstractions;
 using MX.Observability.ApplicationInsights.Auditing;
 using Newtonsoft.Json;
+using System.Net;
 using System.Reflection;
 using System.Security.Claims;
-using System.Net;
 using XtremeIdiots.Portal.Repository.Abstractions.Models.V1.Configurations;
 using XtremeIdiots.Portal.Repository.Api.Client.V1;
 using XtremeIdiots.Portal.Web.Controllers;
@@ -138,6 +138,9 @@ public void PopulateModelFromNamespace_ChatCommandsNamespace_MapsDefaultsAndFuMe
         Assert.Single(fu.Messages);
         Assert.Equal("fu-{name}", fu.Messages[0].Message);
         Assert.True(fu.Messages[0].Enabled);
+
+        var commands = model.ChatCommands.Commands.Single(x => x.Name == "commands");
+        Assert.Equal(["!help"], commands.Aliases);
     }
 
     [Fact]

src/XtremeIdiots.Portal.Web.Tests/ViewModels/GlobalSettingsViewModelTests.cs

@@ -1,4 +1,5 @@
 using System.ComponentModel.DataAnnotations;
+using System.Linq;
 using XtremeIdiots.Portal.Web.ViewModels;
 
 namespace XtremeIdiots.Portal.Web.Tests.ViewModels;
@@ -44,4 +45,14 @@ public void Validate_WhenFunnyMessageIs120Characters_IsValid()
 
         Assert.True(isValid);
     }
+
+    [Fact]
+    public void ChatCommands_DefaultCommandsIncludeAliases()
+    {
+        var model = new ChatCommandGlobalSettingsViewModel();
+
+        var commands = model.Commands.Single(x => x.Name == "commands");
+
+        Assert.Equal(["!help"], commands.Aliases);
+    }
 }

src/XtremeIdiots.Portal.Web/ViewModels/ChatCommandSettingsViewModels.cs

@@ -44,7 +44,8 @@ public class ChatCommandGlobalSettingsViewModel : IValidatableObject
                 Prefix = descriptor.Prefix,
                 Usage = descriptor.Usage,
                 Description = descriptor.Description,
-                IsMutating = descriptor.IsMutating
+                IsMutating = descriptor.IsMutating,
+                Aliases = descriptor.Aliases?.ToList() ?? []
             })
             .ToList();
 
@@ -67,7 +68,8 @@ public class ChatCommandServerSettingsViewModel : IValidatableObject
                 Prefix = descriptor.Prefix,
                 Usage = descriptor.Usage,
                 Description = descriptor.Description,
-                IsMutating = descriptor.IsMutating
+                IsMutating = descriptor.IsMutating,
+                Aliases = descriptor.Aliases?.ToList() ?? []
             })
             .ToList();
 
@@ -92,6 +94,8 @@ public abstract class ChatCommandEntryViewModelBase
 
     public bool IsMutating { get; set; }
 
+    public List<string> Aliases { get; set; } = [];
+
     [DisplayName("Enabled")]
     public bool? Enabled { get; set; }
 

src/XtremeIdiots.Portal.Web/Views/GameServers/ConfigurationSections/_ChatCommandsConfiguration.cshtml

@@ -46,9 +46,17 @@ StringComparison.OrdinalIgnoreCase));
             <input type="hidden" asp-for="ChatCommands.Commands[i].Usage" />
             <input type="hidden" asp-for="ChatCommands.Commands[i].Description" />
             <input type="hidden" asp-for="ChatCommands.Commands[i].IsMutating" />
+            @for (var aliasIndex = 0; aliasIndex < command.Aliases.Count; aliasIndex++)
+            {
+                <input type="hidden" asp-for="ChatCommands.Commands[i].Aliases[aliasIndex]" />
+            }
 
             <div class="mb-3">
                 <div class="small text-muted">@command.Usage</div>
+                @if (command.Aliases.Count > 0)
+                {
+                    <div class="small text-muted">Aliases: @string.Join(", ", command.Aliases)</div>
+                }
                 <p class="text-muted mb-0">@command.Description</p>
             </div>
 

src/XtremeIdiots.Portal.Web/Views/GlobalSettings/_ChatCommandsConfiguration.cshtml

@@ -100,10 +100,20 @@
                                     <input type="hidden" asp-for="ChatCommands.Commands[i].Usage" />
                                     <input type="hidden" asp-for="ChatCommands.Commands[i].Description" />
                                     <input type="hidden" asp-for="ChatCommands.Commands[i].IsMutating" />
+                                    @for (var aliasIndex = 0; aliasIndex < command.Aliases.Count; aliasIndex++)
+                                    {
+                                        <input type="hidden" asp-for="ChatCommands.Commands[i].Aliases[aliasIndex]" />
+                                    }
 
                                     <div class="d-flex justify-content-between align-items-start mb-3">
                                         <div>
                                             <h6 class="mb-1">@command.Prefix</h6>
+                                            @if (command.Aliases.Count > 0)
+                                            {
+                                                <div class="small text-muted mb-1">
+                                                    Aliases: @string.Join(", ", command.Aliases)
+                                                </div>
+                                            }
                                             <div class="small text-muted mb-1">@command.Usage</div>
                                             <p class="text-muted mb-0">@command.Description</p>
                                         </div>

src/XtremeIdiots.Portal.Web/XtremeIdiots.Portal.Web.csproj

@@ -48,7 +48,7 @@
     <PackageReference Include="MX.Api.Abstractions" Version="2.3.31" />
     <PackageReference Include="MX.Api.Client" Version="2.3.31" />
     <PackageReference Include="XtremeIdiots.Portal.Integrations.Servers.Api.Client.V1" Version="2.1.180" />
-    <PackageReference Include="XtremeIdiots.Portal.ChatCommands.Abstractions.V1" Version="1.1.74" />
+    <PackageReference Include="XtremeIdiots.Portal.ChatCommands.Abstractions.V1" Version="1.1.77" />
     <PackageReference Include="XtremeIdiots.Portal.Repository.Api.Client.V1" Version="2.1.250" />
     <PackageReference Include="XtremeIdiots.Portal.Repository.Abstractions.V1" Version="2.1.250" />
     <PackageReference Include="MX.GeoLocation.Api.Client.V1" Version="1.2.39" />