Skip to content

Commit beb9b34

Browse files
fix: Update player retrieval filter to use UsernameAndGuid and enhance player link security in RconPlayers
1 parent c939800 commit beb9b34

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/XtremeIdiots.Portal.Web/Controllers/ServerAdminController.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ private async Task<object> EnrichRconPlayerDataAsync(dynamic rconPlayer, GameTyp
325325
{
326326
// Search for player by GUID using GetPlayers with filter
327327
var playerResponse = await repositoryApiClient.Players.V1.GetPlayers(
328-
gameType, null, guid, 0, 1, PlayersOrder.LastSeenDesc, PlayerEntityOptions.None).ConfigureAwait(false);
328+
gameType, PlayersFilter.UsernameAndGuid, guid, 0, 1, PlayersOrder.LastSeenDesc, PlayerEntityOptions.None).ConfigureAwait(false);
329329

330330
if (playerResponse.IsSuccess && playerResponse.Result?.Data?.Items?.Any() == true)
331331
{
@@ -1509,7 +1509,7 @@ private async Task CreateAdminActionForRconOperationAsync(
15091509
{
15101510
// Try to find existing player profile by searching with GUID
15111511
var playerResponse = await repositoryApiClient.Players.V1.GetPlayers(
1512-
gameType, null, playerGuidStr, 0, 1, PlayersOrder.LastSeenDesc, PlayerEntityOptions.None).ConfigureAwait(false);
1512+
gameType, PlayersFilter.UsernameAndGuid, playerGuidStr, 0, 1, PlayersOrder.LastSeenDesc, PlayerEntityOptions.None).ConfigureAwait(false);
15131513

15141514
if (!playerResponse.IsSuccess || playerResponse.Result?.Data?.Items?.Any() != true)
15151515
{

src/XtremeIdiots.Portal.Web/wwwroot/js/rcon-players.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ var RconPlayers = (function () {
6565
data: 'name', name: 'name',
6666
render: function (data, type, row) {
6767
if (row.playerId) {
68-
return '<a href="/Players/Details/' + row.playerId + '">' + CodColors.renderSafe(row.name) + '</a>';
68+
return '<a href="/Players/Details/' + row.playerId + '" target="_blank" rel="noopener noreferrer">' + CodColors.renderSafe(row.name) + '</a>';
6969
}
7070
return CodColors.renderSafe(row.name);
7171
}

0 commit comments

Comments
 (0)