Skip to content

Commit c7cbb00

Browse files
refactor: Simplify date parsing logic in AgentTelemetryService and improve condition checks in MapRotationCfgParser
1 parent cf05d5c commit c7cbb00

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/XtremeIdiots.Portal.Web/Services/AgentTelemetryService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ private string GetAppInsightsResourceId()
190190
var value = row[index];
191191
return value is DateTimeOffset dto
192192
? dto.UtcDateTime
193-
: value is DateTime dt ? dt : (DateTime?)(DateTime.TryParse(value?.ToString(), out var parsed) ? parsed : null);
193+
: value is DateTime dt ? dt : DateTime.TryParse(value?.ToString(), out var parsed) ? parsed : null;
194194
}
195195

196196
private static int GetIntValue(LogsTableRow row, IReadOnlyList<LogsTableColumn> columns, string columnName)

src/XtremeIdiots.Portal.Web/Services/MapRotationCfgParser.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,11 @@ private static bool IsContinuationVariable(string baseVar, int suffixIndex, stri
112112
{
113113
// sv_maprotation_1, sv_maprotation_2 are continuations of sv_maprotation
114114
// But scr_aacp_maps_1 is NOT a continuation — it's the base variable
115-
return baseVar.Equals("sv_maprotation", StringComparison.OrdinalIgnoreCase) && suffixIndex > 0
116-
? true
117-
: baseVar.Equals("scr_small_rotation", StringComparison.OrdinalIgnoreCase) && suffixIndex > 0 || (baseVar.Equals("scr_med_rotation", StringComparison.OrdinalIgnoreCase) && suffixIndex > 0) || (baseVar.Equals("scr_large_rotation", StringComparison.OrdinalIgnoreCase) && suffixIndex > 0);
115+
return suffixIndex > 0
116+
&& (baseVar.Equals("sv_maprotation", StringComparison.OrdinalIgnoreCase)
117+
|| baseVar.Equals("scr_small_rotation", StringComparison.OrdinalIgnoreCase)
118+
|| baseVar.Equals("scr_med_rotation", StringComparison.OrdinalIgnoreCase)
119+
|| baseVar.Equals("scr_large_rotation", StringComparison.OrdinalIgnoreCase));
118120
}
119121

120122
private static (string BaseVar, int SuffixIndex) ParseVariableSuffix(string varName)

0 commit comments

Comments
 (0)