fix: streamline adaptive sampling settings variable naming in Startup

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Program.cs

@@ -42,10 +42,8 @@ public static IHostBuilder CreateHostBuilder(string[] args)
                             .Select("Google:*", environmentLabel)
                             .Select("FeatureManagement:*", environmentLabel)
                             .ConfigureRefresh(refresh =>
-                            {
                                 refresh.Register("Sentinel", environmentLabel, refreshAll: true)
-                                       .SetRefreshInterval(TimeSpan.FromMinutes(5));
-                            });
+                                       .SetRefreshInterval(TimeSpan.FromMinutes(5)));
 
                         options.ConfigureKeyVault(kv =>
                         {

src/XtremeIdiots.Portal.Web/Startup.cs

@@ -21,7 +21,7 @@ public class Startup(IConfiguration configuration)
 {
     public IConfiguration Configuration { get; } = configuration;
 
-    private readonly SamplingPercentageEstimatorSettings _samplingSettings = new()
+    private readonly SamplingPercentageEstimatorSettings samplingSettings = new()
     {
         InitialSamplingPercentage = double.TryParse(configuration["ApplicationInsights:InitialSamplingPercentage"], out var initPct) ? initPct : 5,
         MinSamplingPercentage = double.TryParse(configuration["ApplicationInsights:MinSamplingPercentage"], out var minPct) ? minPct : 5,
@@ -39,7 +39,7 @@ public void ConfigureServices(IServiceCollection services)
         {
             var telemetryProcessorChainBuilder = telemetryConfiguration.DefaultTelemetrySink.TelemetryProcessorChainBuilder;
             telemetryProcessorChainBuilder.UseAdaptiveSampling(
-                settings: _samplingSettings,
+                settings: samplingSettings,
                 callback: null,
                 excludedTypes: "Exception");
             telemetryProcessorChainBuilder.Build();
@@ -117,13 +117,13 @@ public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
 
         // Update adaptive sampling settings when configuration refreshes
         ChangeToken.OnChange(
-            () => Configuration.GetReloadToken(),
+            Configuration.GetReloadToken,
             () =>
             {
                 if (double.TryParse(Configuration["ApplicationInsights:MinSamplingPercentage"], out var min))
-                    _samplingSettings.MinSamplingPercentage = min;
+                    samplingSettings.MinSamplingPercentage = min;
                 if (double.TryParse(Configuration["ApplicationInsights:MaxSamplingPercentage"], out var max))
-                    _samplingSettings.MaxSamplingPercentage = max;
+                    samplingSettings.MaxSamplingPercentage = max;
             });
 
         if (env.IsDevelopment())