feat: Enhance error display logic for assignments and improve layout for map images

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Views/MapRotations/AssignmentStatus.cshtml

@@ -80,7 +80,7 @@
                             }
                         </dl>
 
-                        @if (!string.IsNullOrEmpty(Model.Assignment.LastError))
+                        @if (!string.IsNullOrEmpty(Model.Assignment.LastError) && Model.Assignment.DeploymentState == DeploymentState.Failed)
                         {
                             <div class="alert alert-danger mt-3 mb-0">
                                 <i class="fa-solid fa-exclamation-triangle"></i> <strong>Last Error</strong>
@@ -329,18 +329,18 @@
                         }
                         else
                         {
-                            <div class="row">
+                            <div class="row g-2">
                                 @{ var sortedMaps = Model.Rotation.MapRotationMaps?.OrderBy(m => m.SortOrder).ToList() ?? []; }
                                 @for (var i = 0; i < sortedMaps.Count; i++)
                                 {
                                     var rotationMap = sortedMaps[i];
                                     var mapDto = Model.Maps.FirstOrDefault(m => m.MapId == rotationMap.MapId);
                                     if (mapDto != null)
                                     {
-                                        <div class="col-md-3 col-sm-4 col-6 mb-3 text-center">
-                                            <img src="@(mapDto.MapImageUri ?? "/images/noimage.jpg")" class="map-image img-fluid" alt="Map image for @mapDto.MapName" loading="lazy" />
-                                            <small class="text-muted">#@(i + 1)</small>
-                                            <h6 class="mb-0">@mapDto.MapName</h6>
+                                        <div class="col-xl-2 col-lg-3 col-md-4 col-sm-4 col-6 mb-2 text-center">
+                                            <img src="@(mapDto.MapImageUri ?? "/images/noimage.jpg")" class="map-image img-fluid rounded" alt="Map image for @mapDto.MapName" loading="lazy" style="max-height: 80px; object-fit: cover; width: 100%;" />
+                                            <small class="text-muted d-block">#@(i + 1)</small>
+                                            <small class="fw-bold">@mapDto.MapName</small>
                                         </div>
                                     }
                                 }

src/XtremeIdiots.Portal.Web/Views/MapRotations/Details.cshtml

@@ -142,7 +142,7 @@
                                                 </td>
                                                 <td>
                                                     @await Html.PartialAsync("_AssignmentStatusBadge", ("Deployment", assignment.DeploymentState.ToString()))
-                                                    @if (!string.IsNullOrEmpty(assignment.LastError))
+                                                    @if (!string.IsNullOrEmpty(assignment.LastError) && assignment.DeploymentState == DeploymentState.Failed)
                                                     {
                                                         <div class="text-danger small mt-1" title="@assignment.LastError">
                                                             <i class="fa-solid fa-exclamation-triangle"></i> @(assignment.LastError.Length > 80 ? assignment.LastError[..80] + "..." : assignment.LastError)