feat: Update orchestration termination method to return detailed result and improve error handling

Author: frasermolyneux

src/XtremeIdiots.Portal.Web/Controllers/MapRotationsController.cs

@@ -848,15 +848,15 @@ public async Task<IActionResult> TerminateOrchestration(string instanceId, Guid
             if (authResult != null)
                 return authResult;
 
-            var terminated = await syncApiClient.TerminateOrchestration(instanceId, cancellationToken).ConfigureAwait(false);
+            var terminateResult = await syncApiClient.TerminateOrchestration(instanceId, cancellationToken).ConfigureAwait(false);
 
-            if (terminated)
+            if (terminateResult.Success)
             {
                 this.AddAlertSuccess($"Orchestration '{instanceId}' terminated. You can now re-trigger the operation.");
             }
             else
             {
-                this.AddAlertDanger($"Failed to terminate orchestration '{instanceId}'. It may have already completed or the sync service is unavailable.");
+                this.AddAlertDanger($"Failed to terminate orchestration '{instanceId}': {terminateResult.Error}");
             }
 
             return RedirectToAction(nameof(AssignmentStatus), new { id = assignmentId });

src/XtremeIdiots.Portal.Web/Services/ISyncApiClient.cs

@@ -7,7 +7,7 @@ public interface ISyncApiClient
     Task<SyncTriggerResult> TriggerDeactivate(Guid assignmentId, CancellationToken cancellationToken = default);
     Task<SyncTriggerResult> TriggerRemove(Guid assignmentId, CancellationToken cancellationToken = default);
     Task<OrchestrationStatusQueryResult> GetOrchestrationStatus(string instanceId, CancellationToken cancellationToken = default);
-    Task<bool> TerminateOrchestration(string instanceId, CancellationToken cancellationToken = default);
+    Task<SyncTriggerResult> TerminateOrchestration(string instanceId, CancellationToken cancellationToken = default);
 }
 
 public record SyncTriggerResult(bool Success, string? InstanceId = null, string? Error = null);

src/XtremeIdiots.Portal.Web/Services/NoOpSyncApiClient.cs

@@ -27,8 +27,8 @@ public Task<OrchestrationStatusQueryResult> GetOrchestrationStatus(string instan
         return Task.FromResult(new OrchestrationStatusQueryResult(OrchestrationStatusQueryOutcome.Error));
     }
 
-    public Task<bool> TerminateOrchestration(string instanceId, CancellationToken cancellationToken = default)
+    public Task<SyncTriggerResult> TerminateOrchestration(string instanceId, CancellationToken cancellationToken = default)
     {
-        return Task.FromResult(false);
+        return Task.FromResult(new SyncTriggerResult(false, Error: "Sync API not configured"));
     }
 }

src/XtremeIdiots.Portal.Web/Services/SyncApiClient.cs

@@ -63,7 +63,7 @@ public async Task<OrchestrationStatusQueryResult> GetOrchestrationStatus(string
         }
     }
 
-    public async Task<bool> TerminateOrchestration(string instanceId, CancellationToken cancellationToken = default)
+    public async Task<SyncTriggerResult> TerminateOrchestration(string instanceId, CancellationToken cancellationToken = default)
     {
         try
         {
@@ -78,16 +78,17 @@ public async Task<bool> TerminateOrchestration(string instanceId, CancellationTo
             if (response.IsSuccessStatusCode)
             {
                 logger.LogInformation("Successfully terminated orchestration {InstanceId}", instanceId);
-                return true;
+                return new SyncTriggerResult(true);
             }
 
-            logger.LogWarning("Failed to terminate orchestration {InstanceId}, status {StatusCode}", instanceId, (int)response.StatusCode);
-            return false;
+            var errorBody = await response.Content.ReadAsStringAsync(cancellationToken).ConfigureAwait(false);
+            logger.LogWarning("Failed to terminate orchestration {InstanceId}, status {StatusCode}: {ErrorBody}", instanceId, (int)response.StatusCode, errorBody);
+            return new SyncTriggerResult(false, Error: $"Sync service returned HTTP {(int)response.StatusCode}: {errorBody}");
         }
         catch (Exception ex)
         {
             logger.LogError(ex, "Failed to terminate orchestration {InstanceId}", instanceId);
-            return false;
+            return new SyncTriggerResult(false, Error: ex.Message);
         }
     }