Enhance Player Details Page and Clipboard Functionality

- Added a "Copy to Clipboard" feature using `data-copy-target` attribute for player ID and GUID.
- Updated PlayersController to reuse intelligence data for related players, reducing API calls.
- Enhanced the RelatedPlayerEnrichedViewModel to include additional fields: LastSeen, HasActiveBan, and AdminActionCount.
- Improved the UI for displaying player details, including admin action counts and risk levels.
- Refactored the IP Intelligence section to provide clearer information and visual feedback.
- Updated the project to use a newer version of the XtremeIdiots.Portal.Repository.Api.Client.V1 package.

Author: frasermolyneux

docs/ui-standards-guide.md

@@ -267,6 +267,25 @@ Examples:
 
 ---
 
+## Copy to Clipboard
+
+Use the `data-copy-target` attribute pattern for copy-to-clipboard actions. Do **not** use inline `onclick` handlers.
+
+```html
+<span id="playerId" class="mx-1">some-value</span>
+<i class="fa-solid fa-fw fa-copy cursor-pointer" data-copy-target="playerId" title="Copy Player ID" aria-hidden="true"></i>
+```
+
+The click handler uses event delegation on `[data-copy-target]`, reads the `textContent` of the target element by ID, and copies it to the clipboard. Visual feedback is provided by temporarily swapping the icon to a checkmark.
+
+### Rules
+
+- The `data-copy-target` value must match the `id` of the element whose text content should be copied.
+- Use `fa-copy` icon with `cursor-pointer` class.
+- Never use `onclick="copyToClipboard(...)"` — use `data-copy-target` instead.
+
+---
+
 ## Badges & Status Indicators
 
 - Use SCSS-defined `badge-*` classes or Bootstrap 5 `bg-*` classes.
@@ -301,3 +320,6 @@ These patterns are deprecated. The SCSS retains bridge definitions for backward
 | `fa-save` | `fa-floppy-disk` |
 | `fa-edit` | `fa-pen-to-square` |
 | `type="button"` on `<a>` | Remove — not valid HTML on anchors |
+| `onclick="copyToClipboard(...)"` | `data-copy-target` attribute |
+| `style="display:none"` on anti-forgery form | `af-hidden` CSS class |
+| Inline `style="height: ..."` on map divs | `player-location-map` CSS class |

src/XtremeIdiots.Portal.Web/Controllers/PlayersController.cs

@@ -82,43 +82,29 @@ public async Task<IActionResult> Details(Guid id, CancellationToken cancellation
 
             if (playerData.RelatedPlayers is not null && playerData.RelatedPlayers.Count != 0)
             {
+                // All related players share the same IP (the current player's IP) — reuse existing intelligence
+                var sharedIntelligence = playerDetailsViewModel.Intelligence;
+
                 foreach (var rp in playerData.RelatedPlayers)
                 {
-                    if (rp is null)
-                    {
-                        continue;
-                    }
+                    if (rp is null) continue;
 
                     var vm = RelatedPlayerEnrichedViewModel.FromRelatedPlayerDto(rp);
-                    try
+
+                    if (sharedIntelligence is not null)
                     {
-                        if (!string.IsNullOrWhiteSpace(vm.IpAddress))
+                        if (!string.IsNullOrWhiteSpace(sharedIntelligence.CountryCode))
+                            vm.CountryCode = sharedIntelligence.CountryCode;
+
+                        if (sharedIntelligence.ProxyCheck is not null)
                         {
-                            var intelligenceResult = await geoLocationClient.GeoLookup.V1_1.GetIpIntelligence(vm.IpAddress, cancellationToken).ConfigureAwait(false);
-                            if (intelligenceResult.IsSuccess && intelligenceResult.Result?.Data is not null)
-                            {
-                                var intelligence = intelligenceResult.Result.Data;
-
-                                if (!string.IsNullOrWhiteSpace(intelligence.CountryCode))
-                                {
-                                    vm.CountryCode = intelligence.CountryCode;
-                                }
-
-                                if (intelligence.ProxyCheck is not null)
-                                {
-                                    vm.RiskScore = intelligence.ProxyCheck.RiskScore;
-                                    vm.IsProxy = intelligence.ProxyCheck.IsProxy;
-                                    vm.IsVpn = intelligence.ProxyCheck.IsVpn;
-                                    vm.ProxyType = intelligence.ProxyCheck.ProxyType;
-                                }
-                            }
+                            vm.RiskScore = sharedIntelligence.ProxyCheck.RiskScore;
+                            vm.IsProxy = sharedIntelligence.ProxyCheck.IsProxy;
+                            vm.IsVpn = sharedIntelligence.ProxyCheck.IsVpn;
+                            vm.ProxyType = sharedIntelligence.ProxyCheck.ProxyType;
                         }
-
-                    }
-                    catch (Exception ex)
-                    {
-                        Logger.LogWarning(ex, "Failed to enrich related player {RelatedPlayerId} for {PlayerId}", vm.PlayerId, id);
                     }
+
                     playerDetailsViewModel.EnrichedRelatedPlayers.Add(vm);
                 }
             }
@@ -141,7 +127,7 @@ public async Task<IActionResult> Details(Guid id, CancellationToken cancellation
     {
         var playerApiResponse = await repositoryApiClient.Players.V1.GetPlayer(id,
             PlayerEntityOptions.Aliases | PlayerEntityOptions.IpAddresses | PlayerEntityOptions.AdminActions |
-            PlayerEntityOptions.RelatedPlayers | PlayerEntityOptions.ProtectedNames | PlayerEntityOptions.Tags).ConfigureAwait(false);
+            PlayerEntityOptions.RelatedPlayers | PlayerEntityOptions.ProtectedNames | PlayerEntityOptions.Tags | PlayerEntityOptions.Counts).ConfigureAwait(false);
 
         if (playerApiResponse.IsNotFound)
         {
@@ -190,7 +176,8 @@ private async Task EnrichCurrentPlayerIntelligenceAsync(PlayerDetailsViewModel v
 
     private async Task EnrichPlayerIpAddressesAsync(PlayerDetailsViewModel viewModel, PlayerDto playerData, Guid playerId, CancellationToken cancellationToken = default)
     {
-        foreach (var ipAddress in playerData.PlayerIpAddresses.OrderByDescending(x => x.LastUsed).Take(10))
+        var ipAddresses = playerData.PlayerIpAddresses.OrderByDescending(x => x.LastUsed).Take(10).ToList();
+        var tasks = ipAddresses.Select(async ipAddress =>
         {
             var enrichedIp = new PlayerIpAddressViewModel
             {
@@ -212,7 +199,10 @@ private async Task EnrichPlayerIpAddressesAsync(PlayerDetailsViewModel viewModel
                     ipAddress.Address, playerId);
             }
 
-            viewModel.EnrichedIpAddresses.Add(enrichedIp);
-        }
+            return enrichedIp;
+        }).ToList();
+
+        var results = await Task.WhenAll(tasks).ConfigureAwait(false);
+        viewModel.EnrichedIpAddresses.AddRange(results);
     }
 }

src/XtremeIdiots.Portal.Web/Styles/features/_players.scss

@@ -88,3 +88,23 @@
         margin-bottom: 0.5rem;
     }
 }
+
+// Player details page
+.player-location-map {
+    height: 200px;
+    width: 100%;
+}
+
+.player-admin-summary {
+    dt {
+        font-weight: $font-weight-semibold;
+        color: $xi-text-muted;
+        font-size: $font-size-sm;
+        text-transform: uppercase;
+    }
+}
+
+// Hidden anti-forgery form
+.af-hidden {
+    display: none;
+}

src/XtremeIdiots.Portal.Web/ViewModels/RelatedPlayerEnrichedViewModel.cs

@@ -12,23 +12,29 @@ public class RelatedPlayerEnrichedViewModel
     public string? IpAddress { get; set; }
     public int GameType { get; set; }
 
-    // Enrichment
+    // Fields from enriched RelatedPlayerDto
+    public DateTime LastSeen { get; set; }
+    public bool HasActiveBan { get; set; }
+    public int AdminActionCount { get; set; }
+
+    // Geo enrichment
     public int? RiskScore { get; set; }
     public bool? IsProxy { get; set; }
     public bool? IsVpn { get; set; }
     public string? ProxyType { get; set; }
     public string? CountryCode { get; set; }
 
-    public static RelatedPlayerEnrichedViewModel FromRelatedPlayerDto(object relatedPlayerDto)
+    public static RelatedPlayerEnrichedViewModel FromRelatedPlayerDto(RelatedPlayerDto dto)
     {
-        // We don't have the concrete type source here; map via dynamic to keep decoupled.
-        dynamic d = relatedPlayerDto;
         return new RelatedPlayerEnrichedViewModel
         {
-            PlayerId = d.PlayerId,
-            Username = d.Username,
-            IpAddress = d.IpAddress,
-            GameType = (int)d.GameType
+            PlayerId = dto.PlayerId,
+            Username = dto.Username,
+            IpAddress = dto.IpAddress,
+            GameType = (int)dto.GameType,
+            LastSeen = dto.LastSeen,
+            HasActiveBan = dto.HasActiveBan,
+            AdminActionCount = dto.AdminActionCount
         };
     }
 }