Merge pull request #589 from K-os/gh_actions_fail_on_err

GH-Actions fail on error

Author: adamjw24

.github/workflows/Build.yml

@@ -77,9 +77,11 @@ jobs:
 
     - name: MSVC build
       if: contains( matrix.config.generators, 'Visual Studio' )
+      shell: pwsh
       run: |
-        cmake -S . -B build/static  -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=0 -DVVENC_OVERRIDE_COMPILER_CHECK=ON -A "${{ matrix.config.msvc_arch }}"
+        $ErrorActionPreference = 'stop'
+        $PSNativeCommandUseErrorActionPreference = $true
+        cmake -S . -B build/static  -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=0 -A "${{ matrix.config.msvc_arch }}"
         cmake --build build/static --config Release
-        cmake -S . -B build/shared  -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=1 -DVVENC_OVERRIDE_COMPILER_CHECK=ON -A "${{ matrix.config.msvc_arch }}"
+        cmake -S . -B build/shared  -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=1 -A "${{ matrix.config.msvc_arch }}"
         cmake --build build/shared --config Release
-      shell: cmd

.gitlab-ci-internal.yml

@@ -257,23 +257,20 @@ test_vs2022_Win32:
   extends: .build_test_msvc_template
   variables:
      MSVC_ARCH: Win32
-     CONFIG_OPTIONS: "-DVVENC_OVERRIDE_COMPILER_CHECK=1"
   tags:
     - vs2022
 
 test_vs2022:
   extends: .build_test_msvc_template
   variables:
      MSVC_ARCH: x64
-     CONFIG_OPTIONS: "-DVVENC_OVERRIDE_COMPILER_CHECK=1"
   tags:
     - vs2022
 
 test_vs2022_arm64:
   extends: .build_test_msvc_template
   variables:
      MSVC_ARCH: arm64
-     CONFIG_OPTIONS: "-DVVENC_OVERRIDE_COMPILER_CHECK=1"
   tags:
     - vs2022-arm