neotest-golang hijacks and prevents "run all tests" in a python project

[mdylanbell]

I'm using a lightly customized LazyVim setup, and use neotest for multiple languages. I have installed the LazyVim extras for python and golang (and probably some others).

When I'm in a python project with tests, and execute Run All Tests (<leader>tT), I almost always get an error from neotest-golang: "The selected directory does not contain a go.mod file or is not part of a Go module". I found this error is prevented if I update M.Adapter.root(dir) function in lua/neotest-golang/init.lua to return nil if a go.mod isn't found, like this:

--- Find the project root directory given a current directory to work from.
--- Should no root be found, the adapter can still be used in a non-project context if a test file matches.
--- @async
--- @param dir string @Directory to treat as cwd
--- @return string | nil @Absolute root dir of test suite
function M.Adapter.root(dir)
  local go_mod_filepath = lib.find.file_upwards("go.mod", dir)

  if go_mod_filepath == nil then
    return nil
  end

  return lib.path.get_directory(go_mod_filepath)
end

This is pretty similar to a patch in the latest release that properly calculates the project root, the difference is it returns dir and not nil if it doesn't find a project root.

I think the main cause is the logger.error here (in lua/runspec/dir.lua):

function M.build(pos, tree)
  local go_mod_filepath = lib.find.file_upwards("go.mod", pos.path)
  if go_mod_filepath == nil then
    logger.error(
      "The selected directory does not contain a go.mod file or is not part of a Go module."
    )
    return nil -- NOTE: logger.error will throw an error, but the LSP doesn't see it.
  end

I found if I change this to logger.info (independently of the above Adapter fix), the problem doesn't occur and my python tests run correctly.

I didn't want to file this as a bug report, because I haven't done the diligence of ensuring this is reproducible with a clean config. I guess I'm just wondering if anyone else has noticed this?

Edit:

Here's the full error output from my neovim notifications:

neotest-golang: ...m/lazy/neotest-golang/lua/neotest-golang/lib/logging.lua:144: The selected directory does not contain a go.mod file or is not part of a Go module.
stack traceback:
	...ocal/share/nvim/lazy/neotest/lua/neotest/client/init.lua:89: in function <...ocal/share/nvim/lazy/neotest/lua/neotest/client/init.lua:88>
	[C]: in function 'error'
	...m/lazy/neotest-golang/lua/neotest-golang/lib/logging.lua:144: in function 'error'
	...m/lazy/neotest-golang/lua/neotest-golang/runspec/dir.lua:87: in function 'build_spec'
	...al/share/nvim/lazy/neotest/lua/neotest/client/runner.lua:76: in function '_run_tree'
	...al/share/nvim/lazy/neotest/lua/neotest/client/runner.lua:65: in function <...al/share/nvim/lazy/neotest/lua/neotest/client/runner.lua:22>
	[C]: in function 'xpcall'
	...ocal/share/nvim/lazy/neotest/lua/neotest/client/init.lua:84: in function 'run_tree'
	...al/share/nvim/lazy/neotest/lua/neotest/consumers/run.lua:85: in function 'func'
	...e/matt/.local/share/nvim/lazy/nvim-nio/lua/nio/tasks.lua:169: in function <...e/matt/.local/share/nvim/lazy/nvim-nio/lua/nio/tasks.lua:168>

[fredrikaverpil]

Hey @mdylanbell would you mind giving the fix/root-v2 a try and see if it works better for you?

{
  "fredrikaverpil/neotest-golang",
  branch = "fix/root-v2"
}

[mdylanbell]

That works! Thanks!

[fredrikaverpil]

Great, thanks for verifying. Releasing this in a minute.