fix: address path switch CI failures

Author: wiwi878

internal/ngap/handler.go

@@ -1304,7 +1304,9 @@ func handlePathSwitchRequestMain(ran *context.AmfRan,
 		receivedEA, receivedIA := receivedNRUESecurityCapability(uESecurityCapabilities)
 		if storedEA != receivedEA || storedIA != receivedIA {
 			// TODO: Include E-UTRA capability once AmfUe stores it; current NGAP builders only preserve NR bits.
-			ranUe.Log.Warnf("UESecurityCapabilities mismatch in PathSwitchRequest: stored NR(EA=0x%02x, IA=0x%02x), received NR(EA=0x%02x, IA=0x%02x); keep stored UE security capability",
+			ranUe.Log.Warnf("UESecurityCapabilities mismatch in PathSwitchRequest: "+
+				"stored NR(EA=0x%02x, IA=0x%02x), received NR(EA=0x%02x, IA=0x%02x); "+
+				"keep stored UE security capability",
 				storedEA, storedIA, receivedEA, receivedIA)
 		}
 	}
@@ -1421,7 +1423,9 @@ func storedNRUESecurityCapability(amfUe *context.AmfUe) (nrEncryptionAlgorithm,
 	return
 }
 
-func receivedNRUESecurityCapability(uESecurityCapabilities *ngapType.UESecurityCapabilities) (nrEncryptionAlgorithm, nrIntegrityAlgorithm byte) {
+func receivedNRUESecurityCapability(
+	uESecurityCapabilities *ngapType.UESecurityCapabilities,
+) (nrEncryptionAlgorithm, nrIntegrityAlgorithm byte) {
 	if len(uESecurityCapabilities.NRencryptionAlgorithms.Value.Bytes) > 0 {
 		nrEncryptionAlgorithm = uESecurityCapabilities.NRencryptionAlgorithms.Value.Bytes[0] & 0xe0
 	}

internal/ngap/handler_test.go

@@ -68,45 +68,6 @@ func NewAmfRan(conn net.Conn) *amf_context.AmfRan {
 	return &ran
 }
 
-func TestHandlePathSwitchRequestKeepsStoredUESecurityCapabilityOnMismatch(t *testing.T) {
-	amfSelf := amf_context.GetSelf()
-	NewAmfContext(amfSelf)
-
-	sourceRan := NewAmfRan(nil)
-	sourceRan.AnType = "3GPP_ACCESS"
-	ranUe, err := sourceRan.NewRanUe(1)
-	require.NoError(t, err)
-
-	amfUe := amfSelf.NewAmfUe("imsi-208930000007487")
-	amfUe.SecurityContextAvailable = true
-	amfUe.NgKsi.Ksi = 1
-	amfUe.Kamf = strings.Repeat("11", 32)
-	amfUe.NH = []byte(strings.Repeat("\x22", 32))
-	amfUe.UESecurityCapability = nasType.UESecurityCapability{
-		Iei:    nasMessage.RegistrationRequestUESecurityCapabilityType,
-		Len:    2,
-		Buffer: []uint8{0x00, 0x00},
-	}
-	amfUe.UESecurityCapability.SetIA2_128_5G(1)
-
-	ranUe.AmfUe = amfUe
-	amfUe.RanUe["3GPP_ACCESS"] = ranUe
-
-	targetRan := NewAmfRan(nil)
-	targetRan.AnType = "3GPP_ACCESS"
-	sourceAMFUeNgapID := ngapType.AMFUENGAPID{Value: ranUe.AmfUeNgapId}
-	ranUeNgapID := ngapType.RANUENGAPID{Value: 2}
-	received := &ngapType.UESecurityCapabilities{}
-	received.NRencryptionAlgorithms.Value = aper.BitString{Bytes: []byte{0x00, 0x00}, BitLength: 16}
-	received.NRintegrityProtectionAlgorithms.Value = aper.BitString{Bytes: []byte{0x00, 0x00}, BitLength: 16}
-
-	handlePathSwitchRequestMain(targetRan, &ranUeNgapID, &sourceAMFUeNgapID, nil, received, nil, nil)
-
-	require.Equal(t, uint8(1), amfUe.UESecurityCapability.GetIA2_128_5G())
-	require.Equal(t, uint8(0), amfUe.UESecurityCapability.GetIA1_128_5G())
-	require.Equal(t, uint8(0), amfUe.UESecurityCapability.GetIA3_128_5G())
-}
-
 func NewAmfContext(amfCtx *amf_context.AMFContext) {
 	*amfCtx = amf_context.AMFContext{
 		NfId: uuid.New().String(),
@@ -196,6 +157,51 @@ func NewAmfContext(amfCtx *amf_context.AMFContext) {
 	}
 }
 
+func TestHandlePathSwitchRequestKeepsStoredUESecurityCapabilityOnMismatch(t *testing.T) {
+	amfSelf := amf_context.GetSelf()
+	NewAmfContext(amfSelf)
+
+	sourceRan := NewAmfRan(nil)
+	sourceRan.AnType = "3GPP_ACCESS"
+	ranUe := &amf_context.RanUe{
+		Ran:         sourceRan,
+		RanUeNgapId: 1,
+		AmfUeNgapId: 1,
+		Log:         sourceRan.Log,
+	}
+	sourceRan.RanUeList.Store(ranUe.RanUeNgapId, ranUe)
+	amfSelf.RanUePool.Store(ranUe.AmfUeNgapId, ranUe)
+
+	amfUe := amfSelf.NewAmfUe("imsi-208930000007487")
+	amfUe.SecurityContextAvailable = true
+	amfUe.NgKsi.Ksi = 1
+	amfUe.Kamf = strings.Repeat("11", 32)
+	amfUe.NH = []byte(strings.Repeat("\x22", 32))
+	amfUe.UESecurityCapability = nasType.UESecurityCapability{
+		Iei:    nasMessage.RegistrationRequestUESecurityCapabilityType,
+		Len:    2,
+		Buffer: []uint8{0x00, 0x00},
+	}
+	amfUe.UESecurityCapability.SetIA2_128_5G(1)
+
+	ranUe.AmfUe = amfUe
+	amfUe.RanUe["3GPP_ACCESS"] = ranUe
+
+	targetRan := NewAmfRan(nil)
+	targetRan.AnType = "3GPP_ACCESS"
+	sourceAMFUeNgapID := ngapType.AMFUENGAPID{Value: ranUe.AmfUeNgapId}
+	ranUeNgapID := ngapType.RANUENGAPID{Value: 2}
+	received := &ngapType.UESecurityCapabilities{}
+	received.NRencryptionAlgorithms.Value = aper.BitString{Bytes: []byte{0x00, 0x00}, BitLength: 16}
+	received.NRintegrityProtectionAlgorithms.Value = aper.BitString{Bytes: []byte{0x00, 0x00}, BitLength: 16}
+
+	handlePathSwitchRequestMain(targetRan, &ranUeNgapID, &sourceAMFUeNgapID, nil, received, nil, nil)
+
+	require.Equal(t, uint8(1), amfUe.UESecurityCapability.GetIA2_128_5G())
+	require.Equal(t, uint8(0), amfUe.UESecurityCapability.GetIA1_128_5G())
+	require.Equal(t, uint8(0), amfUe.UESecurityCapability.GetIA3_128_5G())
+}
+
 func BuildInitialUEMessage(ranUeNgapID int64, nasPdu []byte, fiveGSTmsi string) ngapType.NGAPPDU {
 	var TestPlmn ngapType.PLMNIdentity
 	var tmsi aper.OctetString