Commit fe9651f
committed
fix(sbi/processor): trim inline comments per #61 review
@roundspring2003 asked across PRs for terse one-liner inline
comments and to move technical context to the commit message
and PR body. Drop the multi-line RFC/threat-model notes inline
and keep one-liners. Background:
* RFC 5448 §3 fixes the EAP-AKA' packet layout: 5-byte EAP
header, 1-byte Subtype, 2 reserved bytes, then attribute TLVs
starting at offset 3 of the post-header slice.
* A crafted NAS AuthenticationResponse carrying a 5-byte EAP
payload (type field only) made eapPkt[5:] empty and data[0]
panicked the AUSF (free5gc/free5gc#982).
* Each attribute is a 2-byte header (type, length/4) followed
by value bytes. Without the truncated-header check, data[i+1]
ran off the end on a payload missing the second header byte
(free5gc/free5gc#983).
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>1 parent 452bec8 commit fe9651f
1 file changed
Lines changed: 2 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
713 | 713 | | |
714 | 714 | | |
715 | 715 | | |
716 | | - | |
717 | | - | |
718 | | - | |
719 | | - | |
720 | | - | |
| 716 | + | |
721 | 717 | | |
722 | 718 | | |
723 | 719 | | |
| |||
727 | 723 | | |
728 | 724 | | |
729 | 725 | | |
730 | | - | |
731 | | - | |
732 | | - | |
| 726 | + | |
733 | 727 | | |
734 | 728 | | |
735 | 729 | | |
| |||
0 commit comments