Merge pull request #7 from Jasonkuo23/fix/put-subid-notfound

fix: PUT subId does not exists

Author: Alonza0314

internal/sbi/processor/subscriptions.go

@@ -92,29 +92,30 @@ func ReplaceIndividualSubcription(c *gin.Context) {
 		SuppFeat:          util.StringToPtr(request.SuppFeat),
 	}
 
-	if exists {
-		// Update existing subscription
-		bsfContext.BsfSelf.UpdateSubscription(subId, subscription)
-
-		// Return updated subscription
-		response := models.BsfSubscriptionResp{
-			Events:            subscription.Events,
-			NotifUri:          subscription.NotifUri,
-			NotifCorreId:      subscription.NotifCorreId,
-			Supi:              subscription.Supi,
-			Gpsi:              util.PtrToString(subscription.Gpsi),
-			SnssaiDnnPairs:    subscription.SnssaiDnnPairs,
-			AddSnssaiDnnPairs: subscription.AddSnssaiDnnPairs,
-			SuppFeat:          util.PtrToString(subscription.SuppFeat),
+	if !exists {
+		problemDetail := models.ProblemDetails{
+			Status: http.StatusNotFound,
+			Cause:  "RESOURCE_NOT_FOUND",
 		}
-		c.JSON(http.StatusOK, response)
-	} else {
-		// Create new subscription with given ID
-		subscription.SubId = subId
-		bsfContext.BsfSelf.Subscriptions[subId] = subscription
+		c.JSON(http.StatusNotFound, problemDetail)
+		return
+	}
 
-		c.Status(http.StatusNoContent)
+	// Update existing subscription
+	bsfContext.BsfSelf.UpdateSubscription(subId, subscription)
+
+	// Return updated subscription
+	response := models.BsfSubscriptionResp{
+		Events:            subscription.Events,
+		NotifUri:          subscription.NotifUri,
+		NotifCorreId:      subscription.NotifCorreId,
+		Supi:              subscription.Supi,
+		Gpsi:              util.PtrToString(subscription.Gpsi),
+		SnssaiDnnPairs:    subscription.SnssaiDnnPairs,
+		AddSnssaiDnnPairs: subscription.AddSnssaiDnnPairs,
+		SuppFeat:          util.PtrToString(subscription.SuppFeat),
 	}
+	c.JSON(http.StatusOK, response)
 }
 
 // DeleteIndividualSubcription handles DELETE /subscriptions/{subId}