kern/intr: add bus flag for multi-proc interrupts

Some interrupt types can be signaled on multiple processors.  These need
adjustment to their handling (notably adjustment to counter handling).

Mark clk_intr_event as being multi-processor (it is).

Differential Revision: https://reviews.freebsd.org/D38448

Author: ehem

sys/dev/acpica/acpi_apei.c

@@ -730,7 +730,8 @@ apei_attach(device_t dev)
 			TAILQ_INSERT_TAIL(&sc->nges.ges, ge, nlink);
 			if (sc->nges.swi_ih == NULL) {
 				swi_add(&clk_intr_event, "apei", apei_nmi_swi,
-				    &sc->nges, SWI_CLOCK, INTR_MPSAFE,
+				    &sc->nges, SWI_CLOCK,
+				    INTR_MPSAFE | INTR_MULTIPROC,
 				    &sc->nges.swi_ih);
 				apei_nmi_nges = &sc->nges;
 				apei_nmi = apei_nmi_handler;

sys/kern/kern_intr.c

@@ -1083,18 +1083,22 @@ swi_add(struct intr_event **eventp, const char *name, driver_intr_t handler,
 	    void *arg, int pri, enum intr_type flags, void **cookiep)
 {
 	struct intr_event *ie;
+	int ieflags = IE_SOFT;
 	int error = 0;
 
 	if (flags & INTR_ENTROPY)
 		return (EINVAL);
 
+	if (flags & INTR_MULTIPROC)
+		ieflags |= IE_MULTIPROC;
+
 	ie = (eventp != NULL) ? *eventp : NULL;
 
 	if (ie != NULL) {
 		if (!(ie->ie_flags & IE_SOFT))
 			return (EINVAL);
 	} else {
-		error = intr_event_create(&ie, NULL, IE_SOFT, 0,
+		error = intr_event_create(&ie, NULL, ieflags, 0,
 		    NULL, NULL, NULL, swi_assign_cpu, "swi%d:", pri);
 		if (error)
 			return (error);
@@ -1678,8 +1682,11 @@ static void
 start_softintr(void *dummy)
 {
 
+	KASSERT(clk_intr_event == NULL, ("clk_intr_event non-NULL at %s()",
+	    __func__));
+
 	if (swi_add(&clk_intr_event, "clk", NULL, NULL, SWI_CLOCK,
-	    INTR_MPSAFE, NULL))
+	    INTR_MPSAFE | INTR_MULTIPROC, NULL))
 		panic("died while creating clk swi ithread");
 }
 SYSINIT(start_softintr, SI_SUB_SOFTINTR, SI_ORDER_FIRST, start_softintr,

sys/sys/bus.h

@@ -279,7 +279,8 @@ enum intr_type {
 	INTR_MD1 = 4096,		/* flag reserved for MD use */
 	INTR_MD2 = 8192,		/* flag reserved for MD use */
 	INTR_MD3 = 16384,		/* flag reserved for MD use */
-	INTR_MD4 = 32768		/* flag reserved for MD use */
+	INTR_MD4 = 32768,		/* flag reserved for MD use */
+	INTR_MULTIPROC = 0x10000,	/* interrupt occurs on multiple procs */
 };
 
 enum intr_trigger {