Merge pull request #360 from ma10/freee_a11y_gl-improve-error-messages-20250617

freee_a11y_gl: improve error messages for cases where nonexistent items are referenced.

Author: ma10

tools/lib/freee_a11y_gl/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "freee_a11y_gl"
-version = "0.1.1"
+version = "0.1.2"
 description = "A module to process a11y guidelines data"
 authors = [
     {name = "Masafumi NAKANE", email = "[email protected]"}

tools/lib/freee_a11y_gl/src/freee_a11y_gl/models/content.py

@@ -99,16 +99,22 @@ def __init__(self, gl: Dict[str, Any]):
 
         # Set up relationships
         rel = RelationshipManager()
+        if not Category.get_by_id(gl['category']):
+            raise ValueError(f'Category ID {gl["category"]} referenced in guideline {self.id} does not exist.')
         rel.associate_objects(self, Category.get_by_id(gl['category']))
 
         # Associate checks
         for check_id in gl.get('checks', []):
             from .check import Check  # Import here to avoid circular imports
+            if not Check.get_by_id(check_id):
+                raise ValueError(f'Check ID {check_id} referenced in guideline {self.id} does not exist.')
             rel.associate_objects(self, Check.get_by_id(check_id))
 
         # Associate WCAG success criteria
         for sc in gl.get('sc', []):
             from .reference import WcagSc  # Import here to avoid circular imports
+            if not WcagSc.get_by_id(sc):
+                raise ValueError(f'Success criterion ID {sc} referenced in guideline {self.id} does not exist.')
             rel.associate_objects(self, WcagSc.get_by_id(sc))
 
         # Associate info references

tools/lib/freee_a11y_gl/src/freee_a11y_gl/models/faq/article.py

@@ -45,18 +45,24 @@ def _create_relationships(self, faq: Dict[str, Any]) -> None:
         # Associate tags
         from .tag import FaqTag
         for tag_id in faq['tags']:
+            if not FaqTag.get_by_id(tag_id):
+                raise ValueError(f'Tag ID {tag_id} referenced in FAQ {self.id} does not exist.')
             rel.associate_objects(self, FaqTag.get_by_id(tag_id))
 
         # Associate guidelines if present
         if 'guidelines' in faq:
             from ..content import Guideline
             for gl_id in faq['guidelines']:
+                if not Guideline.get_by_id(gl_id):
+                    raise ValueError(f'Guideline ID {gl_id} referenced in FAQ {self.id} does not exist.')
                 rel.associate_objects(self, Guideline.get_by_id(gl_id))
 
         # Associate checks if present
         if 'checks' in faq:
             from ..check import Check
             for check_id in faq['checks']:
+                if not Check.get_by_id(check_id):
+                    raise ValueError(f'Check ID {check_id} referenced in FAQ {self.id} does not exist.')
                 rel.associate_objects(self, Check.get_by_id(check_id))
 
         # Associate info references if present