Merge pull request #103 from him0/refactor/remove-api-mode

refactor: remove API mode, keep client mode only

Author: him0

.changeset/remove-api-mode.md

@@ -0,0 +1,7 @@
+---
+"@him0/freee-mcp": minor
+---
+
+Remove API mode, keep client mode only
+
+BREAKING CHANGE: `freee-mcp api` subcommand has been removed. The server now only operates in client mode (HTTP method sub-commands). Use `freee-mcp` or `freee-mcp client` to start the server.

.github/workflows/claude.yml

@@ -59,7 +59,7 @@ jobs:
           # assignee_trigger: "claude-bot"
 
           # Optional: Allow Claude to run specific commands
-          allowed_tools: '"Bash(ls:*)",Bash(pnpm install),Bash(pnpm type-check),Bash(pnpm test:*),Bash(pnpm lint),Bash(pnpm format),Bash(pnpm build)'
+          allowed_tools: '"Bash(ls:*)",Bash(pnpm install),Bash(pnpm typecheck),Bash(pnpm test:*),Bash(pnpm lint),Bash(pnpm format),Bash(pnpm build)'
 
           # Optional: Add custom instructions for Claude to customize its behavior for your project
           # custom_instructions: |

CLAUDE.md

@@ -6,7 +6,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 - `pnpm dev` - Start development server with watch mode
 - `pnpm build` - Full build (types + esbuild)
-- `pnpm type-check` - TypeScript type checking
+- `pnpm typecheck` - TypeScript type checking
 - `pnpm lint` - Run ESLint
 - `pnpm inspector` - MCP inspector for debugging tools
 - `node scripts/test-tools.js` - Quick tool verification
@@ -26,25 +26,19 @@ MCP server that exposes freee API endpoints as MCP tools:
   - `pm-api-schema.json` - 工数管理API (https://api.freee.co.jp/pm)
   - `sm-api-schema.json` - 販売API (https://api.freee.co.jp/sm)
 - **Schema Loader**: `src/openapi/schema-loader.ts` loads and manages all API schemas
-- **Tool Generation**: Two modes available (selected via CLI subcommand):
-  - **Client Mode** (`freee-mcp client`): Sub-command tools per HTTP method **[RECOMMENDED]**
-    - `generateClientModeTool()` in `src/openapi/client-mode.ts` creates method-specific tools
-    - Tools: `freee_api_get`, `freee_api_post`, `freee_api_put`, `freee_api_delete`, `freee_api_patch`, `freee_api_list_paths`
-    - Automatically detects API type from path and uses correct base URL
-    - Validates paths against all OpenAPI schemas before execution
-    - Reduces context window usage significantly (6 tools vs hundreds)
-    - Supports all 5 freee APIs seamlessly
-  - **Individual Mode** (`freee-mcp api` or default): One tool per endpoint
-    - `generateToolsFromOpenApi()` in `src/openapi/converter.ts` converts OpenAPI paths to MCP tools
-    - Naming with API prefix: `accounting_get_deals`, `hr_get_employees`, `invoice_get_delivery_slips`, `pm_get_projects`, `sm_get_businesses`
-    - Each tool automatically uses the correct base URL for its API
+- **Tool Generation**: `generateClientModeTool()` in `src/openapi/client-mode.ts` creates method-specific tools
+  - Tools: `freee_api_get`, `freee_api_post`, `freee_api_put`, `freee_api_delete`, `freee_api_patch`, `freee_api_list_paths`
+  - Automatically detects API type from path and uses correct base URL
+  - Validates paths against all OpenAPI schemas before execution
+  - Supports all 5 freee APIs seamlessly
 - **Requests**: `makeApiRequest()` in `src/api/client.ts` handles API calls with auto-auth and company_id injection
 
 ### Configuration
 
 #### Recommended Setup (Config File)
 
 Run `freee-mcp configure` to set up configuration interactively:
+
 - Creates `~/.config/freee-mcp/config.json` with OAuth credentials and company settings
 - No environment variables needed
 - More secure (file permissions 0600)
@@ -60,8 +54,8 @@ Run `freee-mcp configure` to set up configuration interactively:
 
 ### CLI Subcommands
 
-- `freee-mcp client` - Start in client mode (HTTP method sub-commands)
-- `freee-mcp api` - Start in API mode (individual tools per endpoint) [default]
+- `freee-mcp` - Start MCP server
+- `freee-mcp configure` - Interactive configuration setup
 
 ### MCP Configuration
 
@@ -82,68 +76,24 @@ After running `freee-mcp configure`:
 
 Configuration is automatically loaded from `~/.config/freee-mcp/config.json`.
 
-#### Using Environment Variables (Deprecated)
-
-⚠️ **Deprecated: Will be removed in future versions**
-
-**Client Mode (recommended):**
-```json
-{
-  "mcpServers": {
-    "freee": {
-      "command": "npx",
-      "args": ["@him0/freee-mcp", "client"],
-      "env": {
-        "FREEE_CLIENT_ID": "your_client_id",
-        "FREEE_CLIENT_SECRET": "your_client_secret",
-        "FREEE_CALLBACK_PORT": "54321"
-      }
-    }
-  }
-}
-```
-
-**API Mode (individual tools):**
-```json
-{
-  "mcpServers": {
-    "freee": {
-      "command": "npx",
-      "args": ["@him0/freee-mcp", "api"],
-      "env": {
-        "FREEE_CLIENT_ID": "your_client_id",
-        "FREEE_CLIENT_SECRET": "your_client_secret",
-        "FREEE_COMPANY_ID": "your_company_id",
-        "FREEE_CALLBACK_PORT": "54321"
-      }
-    }
-  }
-}
-```
-
-**Client Mode vs Individual Mode**:
-- Use `freee-mcp client` for HTTP method sub-command tools (recommended for large APIs)
-  - 6 tools total: freee_api_{get,post,put,delete,patch} + freee_api_list_paths
-  - Significantly reduces context window usage
-- Use `freee-mcp api` for individual tools per endpoint (more granular but uses more context)
-  - Hundreds of tools (one per API endpoint)
-
-Development mode: Use `"command": "pnpm", "args": ["tsx", "src/index.ts", "client"]` with `"cwd": "/path/to/freee-mcp"`
+Development mode: Use `"command": "pnpm", "args": ["tsx", "src/index.ts"]` with `"cwd": "/path/to/freee-mcp"`
 
 ## PR Creation Pre-flight Checklist
 
 **Always run before creating a PR:**
 
 ```bash
-pnpm type-check && pnpm lint && pnpm test:run && pnpm build
+pnpm typecheck && pnpm lint && pnpm test:run && pnpm build
 ```
 
 **Changeset requirement:**
+
 - Run `pnpm changeset` to create a changeset file for any user-facing changes
 - Select the appropriate bump type: `patch` (bug fixes), `minor` (new features), `major` (breaking changes)
 - Write a concise description of what changed for the CHANGELOG
 
 **Common issues:**
+
 - Mock function return types (ensure `id` fields are strings)
 - Missing return type annotations on exported functions
 - Undefined environment variables in tests

README.md

@@ -49,12 +49,17 @@ npx @him0/freee-mcp configure
   "mcpServers": {
     "freee": {
       "command": "npx",
-      "args": ["@him0/freee-mcp", "client"]
+      "args": ["@him0/freee-mcp"]
     }
   }
 }
 ```
 
+> **⚠️ 環境変数での設定について**
+> 環境変数（`FREEE_CLIENT_ID`、`FREEE_CLIENT_SECRET` など）を使った設定は非推奨です。
+> 代わりに `npx @him0/freee-mcp configure` を実行して設定ファイルに移行してください。
+> 環境変数設定は将来のバージョンで削除される予定です。
+
 ## Claude Plugin として使う
 
 Claude Code でプラグインとしてインストールすると、API リファレンス付きのスキルが利用できます:
@@ -88,25 +93,6 @@ Claude との会話中に API の使い方を質問すると、これらのリ
 例: 「先月の○○社への請求書を参考に、今月分を作成して」
 ```
 
-## 起動モード
-
-freee-mcp は2つのモードで起動できます：
-
-```bash
-# クライアントモード（推奨）：HTTPメソッド別の6ツール
-npx @him0/freee-mcp client
-
-# APIモード：エンドポイントごとの個別ツール（数百個）
-npx @him0/freee-mcp api
-# または
-npx @him0/freee-mcp
-```
-
-| モード | ツール数 | 特徴 | 推奨 |
-| ------ | -------- | ---- | ---- |
-| client | 6個 | コンテキスト使用量が少ない、任意のパスを指定可能 | ✅ |
-| api | 数百個 | エンドポイントごとに専用ツール、コンテキスト消費大 | ❌ |
-
 ## 利用可能なツール
 
 ### 管理ツール
@@ -120,7 +106,7 @@ npx @him0/freee-mcp
 | `freee_help`           | 使い方ガイド               |
 | `freee_status`         | 現在の状態と推奨アクション |
 
-### API ツール（クライアントモード）
+### API ツール
 
 HTTPメソッドごとのシンプルなツール構成:
 
@@ -144,7 +130,7 @@ pnpm install
 
 pnpm dev           # 開発サーバー（ウォッチモード）
 pnpm build         # ビルド
-pnpm type-check    # 型チェック
+pnpm typecheck    # 型チェック
 pnpm lint          # リント
 pnpm test:run      # テスト
 
@@ -156,6 +142,10 @@ pnpm generate:references
 
 TypeScript / Model Context Protocol SDK / OAuth 2.0 + PKCE / Zod / esbuild
 
+### アーキテクチャ詳細
+
+プロジェクトのアーキテクチャ、内部構造、開発ガイドラインについては [CLAUDE.md](./CLAUDE.md) を参照してください。
+
 ## ライセンス
 
 ISC

src/config.ts

@@ -1,9 +1,6 @@
 import { loadFullConfig } from './config/companies.js';
 import { DEFAULT_CALLBACK_PORT, AUTH_TIMEOUT_MS } from './constants.js';
 
-// Mode can be set programmatically via setMode()
-let clientMode = false;
-
 export interface Config {
   freee: {
     clientId: string;
@@ -135,16 +132,3 @@ export const config = new Proxy({} as Config, {
   },
 });
 
-/**
- * Sets the API mode (client or individual tools)
- */
-export function setMode(useClient: boolean): void {
-  clientMode = useClient;
-}
-
-/**
- * Get current mode (client or individual tools)
- */
-export function getMode(): boolean {
-  return clientMode;
-}