Enable HTML in Biome and fix Biome plugin in Trunk Check (#874)

Author: dex4er

.trunk/trunk.yaml

@@ -50,6 +50,39 @@ lint:
         parse_regex: ${semver}
         run: yamlfmt -version
       known_good_version: 0.16.0
+    - name: biome
+      files:
+        - astro
+        - css
+        - graphql
+        - html
+        - javascript
+        - json
+        - sass
+        - typescript
+      commands:
+        - output: regex
+          success_codes:
+            - 0
+            - 1
+          batch: true
+          cache_results: true
+          name: lint
+          parse_regex: " *(?P<path>.*?):(?P<line>\\d+):(?P<col>\\d+) (?P<code>[^ ]+)(?:[^×]*\\n).*× (?P<message>.*)\\n"
+          read_output_from: stderr
+          run: biome check ${target}
+          run_from: ${parent}
+        - output: rewrite
+          success_codes:
+            - 0
+            - 1
+          batch: true
+          cache_results: true
+          formatter: true
+          in_place: true
+          name: fmt
+          run: biome check --fix "${target}"
+          run_from: ${parent}
   enabled:
     - actionlint@1.7.7
     - biome@2.0.0! # datasource=npm depName=@biomejs/biome

biome.jsonc

@@ -1,32 +1,15 @@
 {
   "$schema": "https://biomejs.dev/schemas/2.0.0/schema.json",
-  "vcs": {
-    "enabled": true,
-    "clientKind": "git",
-    "useIgnoreFile": true
-  },
-  "files": {
-    "includes": ["**", "!**/.trunk/**", "!**/build/**", "!**/dist/**", "!**/package.json"]
-  },
-  "formatter": {
-    "attributePosition": "auto",
-    "bracketSpacing": true,
-    "enabled": true,
-    "formatWithErrors": false,
-    "indentStyle": "space",
-    "indentWidth": 2,
-    "lineEnding": "lf",
-    "lineWidth": 120,
-    "useEditorconfig": true
-  },
   "assist": {
     "actions": {
       "source": {
         "organizeImports": {
           "level": "on",
           "options": {
             "groups": [
-              { "type": false },
+              {
+                "type": false
+              },
               ":NODE:",
               ":BLANK_LINE:",
               "@freelensapp/**",
@@ -40,27 +23,63 @@
       }
     }
   },
+  "files": {
+    "includes": ["**", "!**/.trunk/**", "!**/build/**", "!**/dist/**", "!**/package.json"]
+  },
+  "formatter": {
+    "attributePosition": "auto",
+    "bracketSpacing": true,
+    "enabled": true,
+    "formatWithErrors": false,
+    "indentStyle": "space",
+    "indentWidth": 2,
+    "lineEnding": "lf",
+    "lineWidth": 120,
+    "useEditorconfig": true
+  },
+  "html": {
+    "formatter": {
+      "enabled": true
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "arrowParentheses": "always",
+      "attributePosition": "auto",
+      "bracketSameLine": false,
+      "bracketSpacing": true,
+      "jsxQuoteStyle": "double",
+      "quoteProperties": "asNeeded",
+      "quoteStyle": "double",
+      "semicolons": "always",
+      "trailingCommas": "all"
+    }
+  },
   "linter": {
     "enabled": true,
     "rules": {
       "a11y": {
         "noRedundantRoles": "off"
       },
       "complexity": {
-        "noBannedTypes": "off", // should be error later
+        // should be error later
+        "noBannedTypes": "off",
         "noUselessConstructor": "off",
         "noUselessThisAlias": "error",
         "noUselessTypeConstraint": "error"
       },
       "correctness": {
         "noInvalidUseBeforeDeclaration": "error",
-        "noUnusedVariables": "off", // should be error later
+        // should be error later
+        "noUnusedVariables": "off",
         "useExhaustiveDependencies": "off"
       },
       "recommended": false,
       "style": {
         "noNamespace": "error",
-        "noParameterAssign": "off", // should be error later
+        // should be error later
+        "noParameterAssign": "off",
+        "useArrayLiterals": "off",
         "useAsConstAssertion": "error",
         "useBlockStatements": "off",
         "useNamingConvention": {
@@ -69,30 +88,24 @@
             "strictCase": false
           }
         },
-        "useTemplate": "off", // should be error later
-        "useArrayLiterals": "off"
+        // should be error later
+        "useTemplate": "off"
       },
       "suspicious": {
         "noEmptyInterface": "off",
-        "noExplicitAny": "off", // should be error later
+        // should be error later
+        "noExplicitAny": "off",
         "noExtraNonNullAssertion": "error",
         "noMisleadingInstantiator": "error",
-        "noUnsafeDeclarationMerging": "off", // should be error later
+        // should be error later
+        "noUnsafeDeclarationMerging": "off",
         "useNamespaceKeyword": "error"
       }
     }
   },
-  "javascript": {
-    "formatter": {
-      "arrowParentheses": "always",
-      "attributePosition": "auto",
-      "bracketSameLine": false,
-      "bracketSpacing": true,
-      "jsxQuoteStyle": "double",
-      "quoteProperties": "asNeeded",
-      "quoteStyle": "double",
-      "semicolons": "always",
-      "trailingCommas": "all"
-    }
+  "vcs": {
+    "clientKind": "git",
+    "enabled": true,
+    "useIgnoreFile": true
   }
 }

freelens/static/splash.html

@@ -47,8 +47,7 @@ enum columnId {
   lastSeen = "last-seen",
 }
 
-export interface EventsProps
-  extends Partial<KubeObjectListLayoutProps<KubeEvent, KubeEventApi, KubeEventData>> {
+export interface EventsProps extends Partial<KubeObjectListLayoutProps<KubeEvent, KubeEventApi, KubeEventData>> {
   className?: IClassName;
   compact?: boolean;
   compactLimit?: number;

packages/core/src/renderer/components/events/events.tsx

@@ -36,7 +36,9 @@ import type { SearchInputUrlProps } from "../input";
 import type { TableProps, TableRowProps, TableSortCallbacks } from "../table";
 import type { PageFiltersStore } from "./page-filters/store";
 
-export type ListLayoutSearchFilter<I extends ItemObject> = (item: I) => SingleOrMany<string | number | undefined | null>;
+export type ListLayoutSearchFilter<I extends ItemObject> = (
+  item: I,
+) => SingleOrMany<string | number | undefined | null>;
 export type ListLayoutSearchFilters<I extends ItemObject> = Record<string, ListLayoutSearchFilter<I>>;
 export type ListLayoutItemsFilter<I extends ItemObject> = (items: I[]) => I[];
 export type ListLayoutItemsFilters<I extends ItemObject> = Record<string, ListLayoutItemsFilter<I>>;

packages/core/src/renderer/components/item-object-list/list-layout.tsx

@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html lang="en">
   <head>
-    <meta charset="UTF-8">
+    <meta charset="UTF-8" >
   </head>
   <body>
     <div id="app"></div>