fix: Better logs, and ignore gray8 when de-duping.

Author: freezy

LibDmd/Frame/DmdFrame.cs

@@ -138,7 +138,7 @@ public DmdFrame Update(DmdFrame frame)
 			Dimensions = frame.Dimensions;
 			Data = frame.Data;
 			BitLength = frame.BitLength;
-			IsIdentifyFrame = false;
+			IsIdentifyFrame = frame.IsIdentifyFrame;
 
 			#if DEBUG
 			AssertData();
@@ -741,6 +741,27 @@ public void Dump(string path, string prefix = null)
 			}
 		}
 
+		public uint DataHash()
+		{
+			const uint fnvPrime = 16777619;
+			uint hash = 2166136261;
+
+			for (int i = 0; i < Data.Length; i++)
+			{
+				hash ^= Data[i];
+				hash *= fnvPrime;
+			}
+
+			// Final avalanche (mix bits for better distribution)
+			hash += hash << 13;
+			hash ^= hash >> 7;
+			hash += hash << 3;
+			hash ^= hash >> 17;
+			hash += hash << 5;
+
+			return hash;
+		}
+
 		#endregion
 	}
 }

LibDmd/Input/Passthrough/PassthroughGray4Source.cs

@@ -42,7 +42,7 @@ public void NextFrame(DmdFrame frame)
 			_framesGray4Duped.OnNext(frame);
 
 			// de-dupe frame
-			if (_lastFrameFormat.Value == FrameFormat.Gray4 && _lastFrame == frame) {
+			if ((_lastFrameFormat.Value == FrameFormat.Gray4 || _lastFrameFormat.Value == FrameFormat.Gray8) && _lastFrame == frame) {
 				return;
 			}
 
@@ -52,11 +52,11 @@ public void NextFrame(DmdFrame frame)
 		}
 
 		public IObservable<DmdFrame> GetGray4Frames(bool dedupe, bool skipIdentificationFrames) => dedupe
-			? (skipIdentificationFrames ? _framesGray4Deduped.Where(f => !f.IsIdentifyFrame) : _framesGray4Deduped)
-			: (skipIdentificationFrames ? _framesGray4Duped.Where(f => !f.IsIdentifyFrame) : _framesGray4Duped);
+			? skipIdentificationFrames ? _framesGray4Deduped.Where(f => !f.IsIdentifyFrame) : _framesGray4Deduped
+			: skipIdentificationFrames ? _framesGray4Duped.Where(f => !f.IsIdentifyFrame) : _framesGray4Duped;
 
 		public void NextGameName(string gameName) => _gameName.OnNext(gameName);
 
 		public IObservable<string> GetGameName() => _gameName;
 	}
-}
+}

LibDmd/Output/FileOutput/RawOutput.cs

@@ -11,7 +11,7 @@ public class RawOutput : IGray2Destination, IGray4Destination, IResizableDestina
 		public string Name => "Raw Output";
 		public bool IsAvailable => !string.IsNullOrEmpty(_gameName);
 		public bool NeedsDuplicateFrames => false;
-		public bool NeedsIdentificationFrames => false;
+		public bool NeedsIdentificationFrames => true;
 
 		private string _gameName;
 
@@ -76,4 +76,4 @@ public void Dispose()
 			_writer?.Dispose();
 		}
 	}
-}
+}

LibDmd/RenderGraph.cs

@@ -344,7 +344,8 @@ public IDisposable StartRendering(Action onCompleted, Action<Exception> onError
 					// For the output, the converter acts as ISource, implementing the specific
 					// interfaces supported. Currently the following output sources are supported:
 					//
-					//    IColoredGray2Source, IColoredGray4Source, IColoredGray6Source and IRgb24Source.
+					//    IColoredGray2Source, IColoredGray4Source, IColoredGray6Source,
+					//    IRgb565Source and IRgb24Source.
 					//
 					// Other types don't make much sense (i.e. you don't convert *down* to 
 					// IGray2Source).
@@ -356,7 +357,7 @@ public IDisposable StartRendering(Action onCompleted, Action<Exception> onError
 					// will get the IColoredGray4Source converted up to RGB24.
 					if (Converter != null) {
 
-						Logger.Info($"  ** Linking converter {Converter.Name} to {dest.Name}...");
+						Logger.Info($"  ** Connecting converter {Converter.Name} to {dest.Name}...");
 
 						// if converter emits colored gray-2 frames..
 						if (Converter is IColoredGray2Source sourceConverterColoredGray2 && !Converter.IsConnected(dest, FrameFormat.ColoredGray2)) {
@@ -476,6 +477,7 @@ public IDisposable StartRendering(Action onCompleted, Action<Exception> onError
 						if (Converter.IsConnected(dest)) {
 							continue;
 						}
+						Logger.Info($"    -- Converter {Converter.Name} could not be linked with a compatible frame format to {dest.Name}.");
 					}
 
 					// Now here we need to find the most efficient way of passing data from the source
@@ -1070,7 +1072,6 @@ private void Connect(ISource source, IDestination dest, FrameFormat from, FrameF
 								destBitmap.RenderBitmap);
 							break;
 
-
 						default:
 							throw new ArgumentOutOfRangeException(nameof(to), to, null);
 					}
@@ -1966,4 +1967,4 @@ public IniNotFoundException(string path) : base("Could not find DmdDevice.ini at
 	}
 
 	#endregion
-}
+}