fix: Potentially fix crash in PIN2DMD driver.

freezy · freezy · commit 86fc760d69ee · 2023-06-27T23:10:51.000+02:00
diff --git a/LibDmd/Frame/DmdFrame.cs b/LibDmd/Frame/DmdFrame.cs
@@ -242,6 +242,7 @@ public DmdFrame ConvertToGray4()
 
 				switch (BitLength) {
 					case 2:
+					case 3:
 						return Update(FrameUtil.ConvertGrayToGray(Data, 0x0, 0x1, 0x4, 0xf), 4);
 					case 4:
 						throw new ArgumentException("Frame is already gray4.");
@@ -250,7 +251,7 @@ public DmdFrame ConvertToGray4()
 					case 24:
 						return Update(ImageUtil.ConvertToGray(Dimensions, Data, 16), 4);
 					default:
-						throw new ArgumentException("Invalid bit length.");
+						throw new ArgumentException($"Invalid bit length ({BitLength}).");
 				}
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -242,6 +242,7 @@ public DmdFrame ConvertToGray4()`
`242`	`242`
`243`	`243`	`switch (BitLength) {`
`244`	`244`	`case 2:`
	`245`	`+ case 3:`
`245`	`246`	`return Update(FrameUtil.ConvertGrayToGray(Data, 0x0, 0x1, 0x4, 0xf), 4);`
`246`	`247`	`case 4:`
`247`	`248`	`throw new ArgumentException("Frame is already gray4.");`
`@@ -250,7 +251,7 @@ public DmdFrame ConvertToGray4()`
`250`	`251`	`case 24:`
`251`	`252`	`return Update(ImageUtil.ConvertToGray(Dimensions, Data, 16), 4);`
`252`	`253`	`default:`
`253`		`- throw new ArgumentException("Invalid bit length.");`
	`254`	`+ throw new ArgumentException($"Invalid bit length ({BitLength}).");`
`254`	`255`	`}`
`255`	`256`	`}`
`256`	`257`	`}`