Fix number service error messages

Author: frenckatron

custom_components/spook/ectoplasms/number/services/decrement.py

@@ -33,7 +33,7 @@ async def async_handle_service(
         if not math.isclose(amount % entity.step, 0, abs_tol=1e-9):
             msg = (
                 f"Amount {amount} not valid for {entity.entity_id}, "
-                f"it needs to be a multiple of {entity.step}",
+                f"it needs to be a multiple of {entity.step}"
             )
             raise ValueError(msg)
 

custom_components/spook/ectoplasms/number/services/increment.py

@@ -33,7 +33,7 @@ async def async_handle_service(
         if not math.isclose(amount % entity.step, 0, abs_tol=1e-9):
             msg = (
                 f"Amount {amount} not valid for {entity.entity_id}, "
-                f"it needs to be a multiple of {entity.step}",
+                f"it needs to be a multiple of {entity.step}"
             )
             raise ValueError(msg)
 

tests/ectoplasms/number/services/test_increment_decrement.py

@@ -52,6 +52,27 @@ async def test_number_services_handle_string_native_values(
     assert entity.set_value == expected
 
 
+@pytest.mark.parametrize(
+    "service_cls",
+    [increment.SpookService, decrement.SpookService],
+)
+async def test_number_services_raise_readable_error_for_invalid_amount(
+    hass: Any,
+    service_cls: type[increment.SpookService | decrement.SpookService],
+) -> None:
+    """Test invalid amounts raise a readable error."""
+    entity = MockNumberEntity(1.5)
+    call = SimpleNamespace(data={"amount": 0.2})
+
+    with pytest.raises(
+        ValueError,
+        match=escape(
+            "Amount 0.2 not valid for number.test, it needs to be a multiple of 0.5"
+        ),
+    ):
+        await service_cls(hass).async_handle_service(entity, call)
+
+
 @pytest.mark.parametrize(
     "service_cls",
     [increment.SpookService, decrement.SpookService],