normalize windows path

Author: Hajime-san

packages/fresh/src/dev/dev_build_cache.ts

@@ -20,7 +20,7 @@ const WINDOWS_SEPARATOR = pathWin32.SEPARATOR;
 /** Normalize a path to use forward slashes so that generated files
  *  are portable across operating systems (e.g. build on Windows,
  *  deploy on Linux). */
-function toPosix(p: string): string {
+export function toPosix(p: string): string {
   return p.replaceAll(WINDOWS_SEPARATOR, "/");
 }
 

packages/fresh/src/dev/fs_crawl.ts

@@ -1,6 +1,6 @@
 import { type FsAdapter, fsAdapter } from "../fs.ts";
 import type { WalkEntry } from "@std/fs/walk";
-import type { FsRouteFileNoMod } from "./dev_build_cache.ts";
+import { type FsRouteFileNoMod, toPosix } from "./dev_build_cache.ts";
 import * as path from "@std/path";
 import { pathToPattern } from "../router.ts";
 import { CommandType } from "../commands.ts";
@@ -86,7 +86,7 @@ export async function crawlRouteDir<State>(
 
     files.push({
       id,
-      filePath: entry.path,
+      filePath: toPosix(entry.path),
       type,
       pattern,
       routePattern,

packages/fresh/src/dev/fs_crawl_test.ts

@@ -1,6 +1,6 @@
 import { expect } from "@std/expect/expect";
 import { createFakeFs } from "../test_utils.ts";
-import { walkDir } from "./fs_crawl.ts";
+import { crawlRouteDir, walkDir } from "./fs_crawl.ts";
 
 Deno.test("walkDir - ", async () => {
   const fs = createFakeFs({
@@ -43,3 +43,60 @@ Deno.test("walkDir - respects skip patterns", async () => {
     "routes/api/users.ts",
   ]);
 });
+
+Deno.test("crawlRouteDir.filePath - normalized Windows paths", async () => {
+  const fs = createFakeFs({
+    "foo\\bar\\baz.txt": "foo",
+    "D:\\foo\\bar.tsx": "foo",
+  });
+
+  const rawFiles = await crawlRouteDir(fs, "foo", [], () => {});
+
+  if (Deno.build.os === "windows") {
+    expect(rawFiles).toEqual(expect.arrayContaining([
+      {
+        id: "/foo/bar",
+        filePath: "D:/foo/bar.tsx",
+        type: "route",
+        pattern: "/foo/bar",
+        routePattern: "/foo/bar",
+        lazy: true,
+        css: [],
+        overrideConfig: { methods: "ALL" },
+      },
+      {
+        id: "/bar/baz",
+        filePath: "foo/bar/baz.txt",
+        type: "route",
+        pattern: "/bar/baz",
+        routePattern: "/bar/baz",
+        lazy: true,
+        css: [],
+        overrideConfig: { methods: "ALL" },
+      },
+    ]));
+  } else {
+    expect(rawFiles).toEqual(expect.arrayContaining([
+      {
+        id: "/D:/foo/bar",
+        filePath: "D:/foo/bar.tsx",
+        type: "route",
+        pattern: "/D:/foo/bar",
+        routePattern: "/D:/foo/bar",
+        lazy: true,
+        css: [],
+        overrideConfig: { methods: "ALL" },
+      },
+      {
+        id: "/foo/bar/baz",
+        filePath: "foo/bar/baz.txt",
+        type: "route",
+        pattern: "/foo/bar/baz",
+        routePattern: "/foo/bar/baz",
+        lazy: true,
+        css: [],
+        overrideConfig: { methods: "ALL" },
+      },
+    ]));
+  }
+});

packages/fresh/src/test_utils.ts

@@ -7,6 +7,7 @@ import { DEFAULT_CONN_INFO } from "./app.ts";
 import type { Command } from "./commands.ts";
 import { fsItemsToCommands, type FsRouteFile } from "./fs_routes.ts";
 import * as path from "@std/path";
+import { toPosix } from "./dev/dev_build_cache.ts";
 
 const STUB = {} as unknown as Deno.ServeHandlerInfo;
 
@@ -123,7 +124,10 @@ export function createFakeFs(files: Record<string, unknown>): FsAdapter {
     },
     // deno-lint-ignore require-await
     async isDirectory(dir) {
-      return Object.keys(files).some((file) => file.startsWith(dir + "/"));
+      return Object.keys(files).some((file) =>
+        // normalize path to posix before comparing
+        toPosix(file).startsWith(dir + "/")
+      );
     },
     async mkdirp(_dir: string) {
     },