fix: address review feedback

- Normalize registered pathnames when comparing (strip leading /) to
  prevent double-registration of files with inconsistent path formats
- Remove brittle workbox assertion from build test
- Remove permanently-ignored dev server test (dead code)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: bartlomieju

packages/plugin-vite/src/plugins/server_snapshot.ts

@@ -319,13 +319,16 @@ export function serverSnapshot(options: ResolvedFreshViteConfig): Plugin[] {
               }
             }
 
-            // Scan client output directory for any additional files generated by Vite plugins
-            // (e.g., vite-plugin-pwa generates sw.js, manifest.webmanifest, etc.)
-            // that weren't captured in the Vite manifest or public directory
+            // Scan client output directory for any additional files generated
+            // by Vite plugins (e.g., vite-plugin-pwa generates sw.js,
+            // manifest.webmanifest) that aren't in the Vite manifest or
+            // public directory.
             if (await fsAdapter.isDirectory(clientOutDir)) {
-              // Create a Set of already-registered pathnames for fast lookup
+              // Normalize registered pathnames (strip leading /) for comparison
               const registeredPaths = new Set(
-                staticFiles.map((f) => f.pathname),
+                staticFiles.map((f) =>
+                  f.pathname.startsWith("/") ? f.pathname.slice(1) : f.pathname
+                ),
               );
 
               const clientFiles = await fsAdapter.walk(

packages/plugin-vite/tests/build_test.ts

@@ -707,7 +707,6 @@ Deno.test({
 
         const swContent = await swRes.text();
         expect(swContent.length).toBeGreaterThan(0);
-        expect(swContent).toContain("workbox"); // Service worker should contain workbox code
 
         // Test that manifest is accessible
         const manifestRes = await fetch(`${address}/manifest.webmanifest`);

packages/plugin-vite/tests/dev_server_test.ts

@@ -608,40 +608,3 @@ Deno.test({
   sanitizeOps: false,
   sanitizeResources: false,
 });
-
-Deno.test({
-  name: "vite dev - vite-plugin-pwa files are accessible",
-  // Ignored: Known limitation - Vite plugin-generated files (like service workers)
-  // are not accessible in dev mode due to middleware ordering. Fresh's middleware
-  // runs before Vite plugin middlewares, blocking requests before plugins can serve them.
-  // This is a dev-only issue; production builds work correctly.
-  // Fixing this would require architectural changes to Fresh's dev server middleware.
-  ignore: true,
-  fn: async () => {
-    const fixture = path.join(FIXTURE_DIR, "vite_plugin_pwa");
-    await withDevServer(fixture, async (address) => {
-      // Test that service worker is accessible
-      const swRes = await fetch(`${address}/sw.js`);
-      expect(swRes.status).toEqual(200);
-      expect(swRes.headers.get("content-type")).toMatch(/javascript/);
-
-      const swContent = await swRes.text();
-      expect(swContent.length).toBeGreaterThan(0);
-
-      // Test that manifest is accessible
-      const manifestRes = await fetch(`${address}/manifest.webmanifest`);
-      expect(manifestRes.status).toEqual(200);
-      expect(manifestRes.headers.get("content-type")).toMatch(/json/);
-
-      const manifestContent = await manifestRes.json();
-      expect(manifestContent.name).toEqual("Fresh PWA Test");
-
-      // Test that registerSW.js is accessible
-      const registerRes = await fetch(`${address}/registerSW.js`);
-      expect(registerRes.status).toEqual(200);
-      expect(registerRes.headers.get("content-type")).toMatch(/javascript/);
-    });
-  },
-  sanitizeOps: false,
-  sanitizeResources: false,
-});