Skip to content

Commit 8220591

Browse files
bartlomiejuclaude
andcommitted
chore: remove locale sort TODO comments
Plain `<` comparison is correct for route paths (ASCII) and preferable to localeCompare which would reintroduce platform-dependent ordering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 36e06ef commit 8220591

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

packages/fresh/src/fs_routes.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,6 @@ export function sortRoutePaths(a: string, b: string) {
246246
const scoreB = getRoutePathScore(charB, b, bIdx);
247247
if (scoreA === scoreB) {
248248
if (charA !== charB) {
249-
// TODO: Do we need localeSort here or is this good enough?
250249
return charA < charB ? -1 : 1;
251250
}
252251
continue;
@@ -256,7 +255,6 @@ export function sortRoutePaths(a: string, b: string) {
256255
}
257256

258257
if (charA !== charB) {
259-
// TODO: Do we need localeSort here or is this good enough?
260258
return charA < charB ? -1 : 1;
261259
}
262260

0 commit comments

Comments
 (0)