fix in sortRoutePaths: sort files alphabetically

Author: will-weiss

packages/fresh/src/fs_routes.ts

@@ -247,7 +247,7 @@ export function sortRoutePaths(a: string, b: string) {
       if (scoreA === scoreB) {
         if (charA !== charB) {
           // TODO: Do we need localeSort here or is this good enough?
-          return charA < charB ? 0 : 1;
+          return charA < charB ? -1 : 1;
         }
         continue;
       }
@@ -257,7 +257,7 @@ export function sortRoutePaths(a: string, b: string) {
 
     if (charA !== charB) {
       // TODO: Do we need localeSort here or is this good enough?
-      return charA < charB ? 0 : 1;
+      return charA < charB ? -1 : 1;
     }
 
     // If we're at the end of A or B, then we assume that the longer

packages/fresh/src/fs_routes_test.tsx

@@ -1314,35 +1314,40 @@ Deno.test("fsRoutes - sortRoutePaths with groups", () => {
   expect(routes).toEqual(sorted);
 
   routes = [
-    "/_app",
-    "/(authed)/_middleware",
-    "/(authed)/_layout",
-    "/_error",
-    "/(authed)/index",
-    "/login",
-    "/auth/login",
-    "/auth/logout",
-    "/(authed)/(account)/account",
-    "/(authed)/api/slug",
-    "/hooks/github",
-    "/(authed)/[org]/_middleware",
-    "/(authed)/[org]/index",
+    "/_app.tsx",
+    "/app.tsx",
+    "/app/_middleware.tsx",
+    "/(authed)/_middleware.tsx",
+    "/(authed)/_layout.tsx",
+    "/_error.tsx",
+    "/(authed)/index.tsx",
+    "/login.tsx",
+    "/auth/login.tsx",
+    "/auth/logout.tsx",
+    "/(authed)/(account)/account.tsx",
+    "/(authed)/api/slug.tsx",
+    "/hooks/github.tsx",
+    "/(authed)/[org]/_middleware.tsx",
+    "/(authed)/[org]/index.tsx",
   ];
+  // routes.sort(() => Math.random() > 0.5 ? -1 : 1);
   routes.sort(sortRoutePaths);
   sorted = [
-    "/_app",
-    "/_error",
-    "/login",
-    "/auth/login",
-    "/auth/logout",
-    "/hooks/github",
-    "/(authed)/_middleware",
-    "/(authed)/_layout",
-    "/(authed)/index",
-    "/(authed)/api/slug",
-    "/(authed)/(account)/account",
-    "/(authed)/[org]/_middleware",
-    "/(authed)/[org]/index",
+    "/_app.tsx",
+    "/_error.tsx",
+    "/app/_middleware.tsx",
+    "/app.tsx",
+    "/auth/login.tsx",
+    "/auth/logout.tsx",
+    "/hooks/github.tsx",
+    "/login.tsx",
+    "/(authed)/_middleware.tsx",
+    "/(authed)/_layout.tsx",
+    "/(authed)/index.tsx",
+    "/(authed)/api/slug.tsx",
+    "/(authed)/(account)/account.tsx",
+    "/(authed)/[org]/_middleware.tsx",
+    "/(authed)/[org]/index.tsx",
   ];
   expect(routes).toEqual(sorted);
 });