fix: basePath not working in dev server

Author: marvinhagemeister

packages/fresh/src/app.ts

@@ -330,7 +330,7 @@ export class App<State> {
       if (cmd.type !== CommandType.App && cmd.type !== CommandType.NotFound) {
         const clone = {
           ...cmd,
-          pattern: mergePath(path, cmd.pattern),
+          pattern: mergePath(path, cmd.pattern, true),
           includeLastSegment: cmd.pattern === "/" || cmd.includeLastSegment,
         };
         this.#commands.push(clone);

packages/fresh/src/commands.ts

@@ -273,6 +273,7 @@ function applyCommandsInner<State>(
           const routePath = mergePath(
             basePath,
             config?.routeOverride ?? pattern,
+            false,
           );
 
           let def: Route<State>;
@@ -304,6 +305,7 @@ function applyCommandsInner<State>(
           const routePath = toRoutePath(mergePath(
             basePath,
             route.config?.routeOverride ?? pattern,
+            false,
           ));
 
           if (typeof route.handler === "function") {
@@ -333,7 +335,7 @@ function applyCommandsInner<State>(
 
         result.push(...fns);
 
-        const resPath = toRoutePath(mergePath(basePath, pattern));
+        const resPath = toRoutePath(mergePath(basePath, pattern, false));
         if (method === "ALL") {
           router.add("GET", resPath, result);
           router.add("DELETE", resPath, result);

packages/fresh/src/dev/builder_test.ts

@@ -389,6 +389,42 @@ Deno.test({
   sanitizeResources: false,
 });
 
+Deno.test({
+  name: "Builder - dev server supports basePath",
+  fn: async () => {
+    const root = path.join(import.meta.dirname!, "..", "..");
+    await using _tmp = await withTmpDir({ dir: root, prefix: "tmp_builder_" });
+    const tmp = _tmp.dir;
+
+    const app = new App({ basePath: "/foo/bar" })
+      .get("/", () => new Response("ok"))
+      .get("/asdf", () => new Response("ok"));
+
+    const builder = new Builder({
+      root: tmp,
+      outDir: path.join(tmp, "dist"),
+    });
+
+    const controller = new AbortController();
+    let address;
+    await builder.listen(() => Promise.resolve<App<unknown>>(app), {
+      signal: controller.signal,
+      onListen(addr) {
+        address = `http://localhost:${addr.port}`;
+      },
+    });
+
+    const res = await fetch(`${address}/foo/bar/asdf`);
+
+    const text = await res.text();
+    expect(text).toEqual("ok");
+
+    controller.abort();
+  },
+  sanitizeOps: false,
+  sanitizeResources: false,
+});
+
 Deno.test({
   name: "Builder - serves static files in subdir",
   fn: async () => {

packages/fresh/src/router.ts

@@ -284,11 +284,15 @@ export function patternToSegments(
   return out;
 }
 
-export function mergePath(basePath: string, path: string): string {
+export function mergePath(
+  basePath: string,
+  path: string,
+  isMounting: boolean,
+): string {
   if (basePath.endsWith("*")) basePath = basePath.slice(0, -1);
   if (basePath === "/") basePath = "";
 
-  if (path === "*") path = "";
+  if (path === "*") path = isMounting ? "" : "/*";
   else if (path === "/*") path = "/*";
 
   const s = (basePath !== "" && path === "/") ? "" : path;

packages/fresh/src/router_test.ts

@@ -155,12 +155,22 @@ Deno.test("patternToSegments", () => {
 });
 
 Deno.test("mergePath", () => {
-  expect(mergePath("", "/foo")).toEqual("/foo");
-  expect(mergePath("/", "/foo")).toEqual("/foo");
-  expect(mergePath("/foo/bar", "/")).toEqual("/foo/bar");
-  expect(mergePath("/foo/bar", "/baz")).toEqual("/foo/bar/baz");
-  expect(mergePath("*", "/baz")).toEqual("/baz");
-  expect(mergePath("/*", "/baz")).toEqual("/baz");
-  expect(mergePath("/foo", "*")).toEqual("/foo");
-  expect(mergePath("/foo", "/*")).toEqual("/foo/*");
+  expect(mergePath("", "/foo", false)).toEqual("/foo");
+  expect(mergePath("/", "/foo", false)).toEqual("/foo");
+  expect(mergePath("/foo/bar", "/", false)).toEqual("/foo/bar");
+  expect(mergePath("/foo/bar", "/baz", false)).toEqual("/foo/bar/baz");
+  expect(mergePath("*", "/baz", false)).toEqual("/baz");
+  expect(mergePath("/*", "/baz", false)).toEqual("/baz");
+  expect(mergePath("/foo", "*", false)).toEqual("/foo/*");
+  expect(mergePath("/foo", "/*", false)).toEqual("/foo/*");
+
+  // mounting
+  expect(mergePath("", "/foo", true)).toEqual("/foo");
+  expect(mergePath("/", "/foo", true)).toEqual("/foo");
+  expect(mergePath("/foo/bar", "/", true)).toEqual("/foo/bar");
+  expect(mergePath("/foo/bar", "/baz", true)).toEqual("/foo/bar/baz");
+  expect(mergePath("*", "/baz", true)).toEqual("/baz");
+  expect(mergePath("/*", "/baz", true)).toEqual("/baz");
+  expect(mergePath("/foo", "*", true)).toEqual("/foo");
+  expect(mergePath("/foo", "/*", true)).toEqual("/foo/*");
 });