Enforced server-only imports

[bbqsrc]

I have an issue where I do not want certain files to ever appear in the Fresh bundle on the frontend, and importing anything from those files should be considered a build error. I cannot find a documented or undocumented way to achieve this.

[bbqsrc]

Okay but that seems to just be checking for node imports. I’m talking about server side functionality that shouldn’t be bundled nor used in islands. But even then, Deno functions are also not accessible in the browser and that’s how I found this occurring.

[marvinhagemeister]

I’m talking about server side functionality that shouldn’t be bundled nor used in islands

Have you tried adding a custom rule?

// vite.config.ts
export default defineConfig({
  plugins: [
    fresh({
      checkImports: [(id, env) => {
        if (id === "dont-import-in-browser.ts" && env === "client") {
          return {
            type: "error",
            message: "You should not import this in the browser",
          };
        }
      }],
    }),
  ],
});

Regarding the Deno global that's something that still needs to be added.

[marvinhagemeister]

Re-opening because we don't yet catch the Deno global.

[CertainLach]

#3305 did block the Deno global... But it also broke the jsr:@std library, as any import of @std/internal will fail due to this error, even when there are shims for environments without Deno globals:

E.g.: importing @std/assert imports this file: https://jsr.io/@std/internal/1.0.10/format.ts, and it triggers the error

Fixed in #3370

[CertainLach]

Unfortunately, some other std library modules might trigger the error, e.g styles.ts contains such construction:

const noColor = typeof Deno?.noColor === "boolean"
  ? Deno.noColor as boolean
  : false;

It was pretty easy to avoid in my code, but still unfortunate that not all of jsr:@std is supported in fresh.

I see disabling this lint for @std as a solution (Or, maybe, for every module from outside?), but this is still a poor solution.

...Maybe this check should be removed from vite plugin, and instead moved to linter? #3179