Fix #2850: Prevent input value leakage by generating unique keys for PartialComp#2857
Closed
SisyphusZheng wants to merge 3 commits into
Closed
Fix #2850: Prevent input value leakage by generating unique keys for PartialComp#2857SisyphusZheng wants to merge 3 commits into
SisyphusZheng wants to merge 3 commits into
Conversation
…e when switching partials, which fixes input value leakage issues to slove the Open ISSUE #2850
fix the issue#2863,because the deno-puppeteer last updated is 3 year ago, and it is not suitable for deno2, we can use npm to slove the problem
SisyphusZheng
changed the title
marvinhagemeister
suggested changes
Apr 27, 2025
Contributor
There was a problem hiding this comment.
Thanks for opening a PR. Please split up this PR into multiple so that every PR does only one thing. This is crucial in open source to be able to do git bisect in the future in case something goes wrong.
To properly link issues in PR descriptions, leave out the issue prefix:
// wrong
ISSUE#1234
// correct
#1234
SisyphusZheng
changed the title
Contributor
Author
|
THX FOR U ADVIES, I WILL REOPEN NEW PR TO FIX THAT,🙇 |
Contributor
Author
|
Thx for ur advice, I did change to the new pr,#2866 u have time plz check this, thx again!🙏
发送自 Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Marvin Hagemeister ***@***.***>
发送时间: Monday, April 28, 2025 1:56:19 AM
收件人: denoland/fresh ***@***.***>
抄送: zhizheng ***@***.***>; Author ***@***.***>
主题: Re: [denoland/fresh] Fix:fix the ISSUE#2850 and #2863 for input value leakage due to vnode reuse and Puppeteer screenshot functionality (PR #2857)
@marvinhagemeister requested changes on this pull request.
Thanks for opening a PR. Please split up this PR into multiple so that every PR does only one thing. This is crucial in open source to be able to do git bisect in the future in case something goes wrong.
—
Reply to this email directly, view it on GitHub<#2857 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BC2V34TBSHAFPWI4CLZJZCL23UK4HAVCNFSM6AAAAAB3YBDQJKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOJXG4YDKMZQGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the ISSUE#2850 and ISSUE#2863 for input value leakage due to vnode reuse and Puppeteer screenshot functionality @marvinhagemeister if u have time plz check this change, thx!