Skip to content

refactor(core): minor fresh/compat cleanups#2880

Merged
marvinhagemeister merged 9 commits into
freshframework:mainfrom
iuioiua:remove-compat
May 19, 2025
Merged

refactor(core): minor fresh/compat cleanups#2880
marvinhagemeister merged 9 commits into
freshframework:mainfrom
iuioiua:remove-compat

Conversation

@iuioiua

@iuioiua iuioiua commented May 2, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the changes. What's the benefit of making it more difficult to update from Fresh 1.x to 2.x?

@iuioiua

iuioiua commented May 6, 2025

Copy link
Copy Markdown
Contributor Author

My bad. I re-checked the purpose of the file. Changes reverted.

@iuioiua iuioiua changed the title BREAKING(core): remove compat types chore(www): minor fresh/compat cleanups May 6, 2025
@iuioiua iuioiua requested a review from marvinhagemeister May 6, 2025 02:38

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister

Copy link
Copy Markdown
Contributor

Can you rebase against main?

@iuioiua iuioiua changed the title chore(www): minor fresh/compat cleanups refactor(core): minor fresh/compat cleanups May 12, 2025
@iuioiua iuioiua requested a review from marvinhagemeister May 18, 2025 23:35

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 144ed2e into freshframework:main May 19, 2025
7 checks passed
@iuioiua iuioiua deleted the remove-compat branch May 19, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants