Skip to content

fix(core): unblock CI#2891

Closed
iuioiua wants to merge 2 commits into
freshframework:mainfrom
iuioiua:revert-check
Closed

fix(core): unblock CI#2891
iuioiua wants to merge 2 commits into
freshframework:mainfrom
iuioiua:revert-check

Conversation

@iuioiua

@iuioiua iuioiua commented May 6, 2025

Copy link
Copy Markdown
Contributor

This will pass upon the next patch release of Deno due to recent formatting changes.

@iuioiua iuioiua marked this pull request as draft May 6, 2025 01:07
@iuioiua iuioiua changed the title fix(core): revert check task change fix(core): unblock CI May 6, 2025
@iuioiua iuioiua marked this pull request as ready for review May 6, 2025 02:38
@iuioiua

iuioiua commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@bartlomieju, just letting you know that this formatting change is blocking CI for this repo. I doubt it alone is enough to justify a patch update to the Deno runtime though.

@marvinhagemeister

Copy link
Copy Markdown
Contributor

Let's go with the release builds as the authority until a new canary builds is released.

@iuioiua

iuioiua commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

Let's go with the release builds as the authority until a new canary builds is released.

Sorry if I was unclear, but yes, that's the idea behind this PR. It's only supposed to be merged once the current canary is the new release.

@iuioiua

iuioiua commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

This'll automatically get fixed once the next Deno release is out.

@iuioiua iuioiua closed this May 12, 2025
@iuioiua iuioiua deleted the revert-check branch May 12, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants