Skip to content

tests: fix leaks, macOS hangs and utility cleanups #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marvinhagemeister merged 3 commits into from
May 7, 2025
Merged

tests: fix leaks, macOS hangs and utility cleanups #2897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c7da8f
fix(init): hang on macOS
iuioiua May 7, 2025
a1d2429
tweaks
iuioiua May 7, 2025
6954bd6
fix leaks
iuioiua May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"@std/semver": "jsr:@std/semver@1",
"@std/streams": "jsr:@std/streams@1",

"@astral/astral": "jsr:@astral/astral@^0.4.6",
"@astral/astral": "jsr:@astral/astral@^0.5.2",
"@marvinh-test/fresh-island": "jsr:@marvinh-test/fresh-island@^0.0.1",
"linkedom": "npm:linkedom@^0.16.11",
"@std/async": "jsr:@std/async@1",
Expand Down
188 changes: 176 additions & 12 deletions deno.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions init/src/init_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ Deno.test("init - can start dev server", async () => {
await patchProject(dir);
await withChildProcessServer(
dir,
path.join(dir, "dev.ts"),
"dev",
async (address) => {
await withBrowser(async (page) => {
await page.goto(address);
Expand All @@ -201,7 +201,7 @@ Deno.test("init - can start built project", async () => {

// Build
await new Deno.Command(Deno.execPath(), {
args: ["run", "-A", path.join(dir, "dev.ts"), "build"],
args: ["task", "build"],
stdin: "null",
stdout: "piped",
stderr: "piped",
Expand All @@ -210,7 +210,7 @@ Deno.test("init - can start built project", async () => {

await withChildProcessServer(
dir,
path.join(dir, "main.ts"),
"start",
async (address) => {
await withBrowser(async (page) => {
await page.goto(address);
Expand All @@ -234,7 +234,7 @@ Deno.test("init - errors on missing build cache in prod", async () => {
await patchProject(dir);

const cp = await new Deno.Command(Deno.execPath(), {
args: ["run", "-A", "main.ts"],
args: ["task", "start"],
stdin: "null",
stdout: "piped",
stderr: "piped",
Expand Down
4 changes: 0 additions & 4 deletions tests/active_links_test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,6 @@ Deno.test({
assertSelector(doc, "a[href='/'][data-ancestor]");
assertSelector(doc, `a[href='/'][aria-current="true"]`);
},
sanitizeResources: false,
sanitizeOps: false,
});

Deno.test({
Expand Down Expand Up @@ -176,6 +174,4 @@ Deno.test({
assertSelector(doc, `a[href='/'][aria-current="true"]`);
});
},
sanitizeResources: false,
sanitizeOps: false,
});
Loading
Loading