tests: use the same browser instance across tests and better use explicit resource management#2901
Merged
marvinhagemeister merged 10 commits intoMay 21, 2025
Conversation
iuioiua
commented
May 8, 2025
Comment on lines
+39
to
+46
| const browser = await launch({ | ||
| args: ["--window-size=1280,720"], | ||
| headless: true, | ||
| }); | ||
|
|
||
| addEventListener("unload", async () => { | ||
| await browser.close(); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
@lino-levan, when I use await using, tests hang.
| - name: Type check project | ||
| run: deno task check:types | ||
|
|
||
| - name: Disable AppArmor |
Contributor
Author
There was a problem hiding this comment.
I think this is worth trying.
iuioiua
changed the title
iuioiua
changed the title
Contributor
Author
|
PTAL @marvinhagemeister |
Contributor
Author
|
@marvinhagemeister, are you able to please take a look? It'd be great to have this bump in test performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine, reduces time taken to perform
deno task testfrom ~1m20s to ~30s.Inspired by and supersedes #2110.