Skip to content

fix: update dependency versions#2917

Closed
csvn wants to merge 1 commit into
freshframework:mainfrom
csvn:fix/update-dependencies
Closed

fix: update dependency versions#2917
csvn wants to merge 1 commit into
freshframework:mainfrom
csvn:fix/update-dependencies

Conversation

@csvn

@csvn csvn commented May 10, 2025

Copy link
Copy Markdown
Contributor

I had an issue while using Fresh alpha where I got errors because I was using v2.0.4 of @preact/signals. I had to ensure I was using v1.x, because jsr:@fresh/core had a dependency on the 1.x version. The errors said something about "effect() is already running", when the library was loaded twice, and it was hard to figure out what the root issue was.

Is there a way to set a version range with deno.json imports? I could not find support for range (-) or OR (||), that can be done with package.json.

Is there a reason not to use the v2 version of Signals? If this PR does something dumb, I don't mind it being closed. I was just surprised a newly generated Fresh project had to use the "old" signals major.

@csvn

csvn commented May 10, 2025

Copy link
Copy Markdown
Contributor Author

Oh, I see a lot of test errors. It seems the v2 signal version with it's requestAnimationFrame usage is not compatible with Fresh without some work, and a lot of values are undefined instead of their expected values 🤔

@iuioiua

iuioiua commented May 10, 2025

Copy link
Copy Markdown
Contributor

I'd hold off on this PR until #2900 is merged.

@csvn

csvn commented May 11, 2025

Copy link
Copy Markdown
Contributor Author

True, it's probably better to address the @preact/signals issue separately. I also found it weird with dependency versions being repeated, so making use of workspace for consolidated versions in #2900 makes sense.

@csvn csvn closed this May 11, 2025
@csvn csvn deleted the fix/update-dependencies branch May 21, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants