docs: fix markdown docs#3459
Merged
Merged
Conversation
|
|
||
| 1. Run `deno install jsr:@deno/gfm` | ||
| 2. Create a markdown file like `content.md`: | ||
| 1. Run `deno install --allow-scripts jsr:@deno/gfm` |
Contributor
There was a problem hiding this comment.
Nit JSR packages don't have postinstall scripts like npm. The --allow-scripts flag does nothing here.
Contributor
Author
There was a problem hiding this comment.
Yeah, but I try to align to docs to a freshly installed demo app with @fresh/init. When I run that command without --allow-scripts, I get warnings about scripts for Tailwind, at least. Also the Vite script seems to run for the first time when run with --allow-scripts, so I almost habitually include that everywhere now.
I'll remove that option.
Contributor
|
A couple of things I noticed:
|
- Use define.page() in a route file instead of old App/ctx.render API - Use @/utils.ts import consistent with other examples - Fix route path to routes/markdown.tsx - Use inline lint-ignore comments instead of file-level directive - Remove external tutorial link (could go stale) - Fix step numbering (was skipping step 3) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bartlomieju
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the markdown docs.
Notes:
main.tswill not work,main.tsxis not supported, so a real route is needed