Skip to content

test: some refactoring (WIP)#3469

Closed
fry69 wants to merge 15 commits into
freshframework:mainfrom
fry69:fry69/refactor-tests-5
Closed

test: some refactoring (WIP)#3469
fry69 wants to merge 15 commits into
freshframework:mainfrom
fry69:fry69/refactor-tests-5

Conversation

@fry69

@fry69 fry69 commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

This PR aims to centralize test helper function and anything that requires cross package imports inside the Fresh monorepo under a new not exported @fresh/internal package.

See also the this reverse engineered design document for a bit more background.

Please comment if there is interest, if this refactor is desired.

@bartlomieju

Copy link
Copy Markdown
Contributor

Thanks for putting this together and for the design doc! We appreciate the effort to clean up the test infrastructure.

After reviewing, we don't think the churn is justified here — the current relative imports for test utils work fine, and introducing a new @fresh/internal package adds maintenance overhead (workspace config, import map changes across 37 files) without a user-facing benefit. The cross-package import ergonomics issue is minor enough that we'd rather keep things simple.

Closing for now, but thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants