fix: resolve server entry filename from bundle chunks#3719
Merged
Conversation
When users customize rollupOptions.output.entryFileNames, the server entry file gets renamed but the generated server.js still imported from the default "server-entry.mjs". Fix by reading the entry filename directly from the bundle chunks, which always reflects the actual output filename regardless of rollup config overrides. Closes #3655 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bartlomieju
changed the title
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollupOptions.output.entryFileNamesin their vite config, the server entry file gets renamed but the generatedserver.jsstill tried to import"./server/server-entry.mjs"(the hardcoded fallback)Closes #3655
Test plan
rollupOptions.output.entryFileNamesto a custom value (e.g.abc.js), rundeno task build && deno task start— server should start without "Module not found" errorentryFileNames) still works as before🤖 Generated with Claude Code