fix: add @types/babel__core to vite project template#3723
Merged
Conversation
New projects using nodeModulesDir: "manual" fail type-checking because Deno can't resolve the @types/babel__core types needed by @fresh/plugin-vite's @babel/core import. Adding it explicitly to the init template fixes the issue. Closes #3605 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bartlomieju
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodeModulesDir: "manual"faildeno checkbecause Deno can't resolve types for@babel/core(imported by@fresh/plugin-vite)@types/babel__coreto the init template's imports so new Vite-based projects include it explicitlyCloses #3605
Test plan
deno run -A jsr:@fresh/init, create a new project with Vite@types/babel__coreappears in the generateddeno.jsonimportsdeno task check/deno check— should pass without manually installing@types/babel__core🤖 Generated with Claude Code