fix: CSP user directives now override defaults instead of duplicating#3724
Merged
Conversation
…#3552) User-provided CSP directives with the same directive name as a default (e.g. img-src) were appended alongside the default, producing duplicate directives in the header. Now user directives replace defaults that share the same directive name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rride # Conflicts: # packages/fresh/src/middlewares/csp.ts # packages/fresh/src/middlewares/csp_test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
img-src 'self' https://example.com data:) now replace the default directive with the same name, instead of being appended alongside itBefore
Duplicate
img-src— browsers use the first one and ignore the override.After
Single
img-srcwith the user's value.Implementation
Extracts directive names from user-provided CSP strings, filters out defaults that share the same name, then appends the user's directives. New directives not in the defaults (like
frame-src) are added as before.Test plan
img-srcoverride produces exactly oneimg-srcdirectivefont-srcandstyle-srcoverrides don't duplicate🤖 Generated with Claude Code