fix: keep ?fresh-partial an implementation detail#3776
Merged
Conversation
CertainLach
force-pushed
the
push-nyyqqyrpmnkv
branch
from
9d5aacb to
944d4d3
Compare
bartlomieju
reviewed
Apr 23, 2026
bartlomieju
left a comment
bartlomieju
left a comment
Contributor
There was a problem hiding this comment.
Could you add a test for it?
7 tasks
- Redirect via link click should not create a back-button trap (back should go to the page before the redirect, not the redirect source) - Redirect should not leak ?fresh-partial in the URL bar
bartlomieju
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering redirect during route change with partials enabled, url in address bar (history api) is being left as ?fresh-partial=true, this doesn't seem right