Merge branch 'post-endpoints' into release-candidate

Author: gekinci

README.md

@@ -88,17 +88,17 @@ Generated artifacts that persist across runs:
 | `GET` | `/api/chatbot/help` | Help payload stub | Placeholder |
 | `GET` | `/api/chatbot/availablechatbots` | Returns model names from `litellm_config.yaml` | Requires auth |
 | `GET` | `/api/chatbot/newthread` | Generates a fresh `thread_id` | Requires auth |
-| `GET` | `/api/chatbot/getthread?thread_id=...` | Fetches thread contents omitting prompts + redundant StreamEnd variants | Requires auth |
-| `GET` | `/api/chatbot/getuserthreads` | Returns latest 10 threads for authenticated user | Falls back to query `user_id` only if `ALLOW_FALLBACK_OLD_AUTH` |
-| `GET` | `/api/chatbot/streamresponse` | Starts an SSE stream of `StreamVariant` JSON payloads | Query params: `thread_id`, `input` (required), `chatbot` |
-| `GET/POST` | `/api/chatbot/stop` | Initiates stopping of an active conversation | Requires auth |
+| `POST` | `/api/chatbot/getthread` | Fetches thread contents omitting prompts + redundant StreamEnd variants | Requires auth |
+| `POST` | `/api/chatbot/getuserthreads` | Returns recent threads for authenticated user | JSON body: `num_threads`, `page` |
+| `POST` | `/api/chatbot/streamresponse` | Starts an SSE stream of `StreamVariant` JSON payloads | Query params: `thread_id`, `input` (required), `chatbot` |
+| `POST` | `/api/chatbot/stop` | Initiates stopping of an active conversation | JSON body: `thread_id`; requires auth |
 
 ### Streaming contract
 - Response type: `application/x-ndjson`
 - Each `data:` line is a JSON object with `variant` discriminators (`Assistant`, `Code`, `CodeOutput`, `CodeError`, `Image`, `ServerHint`, `StreamEnd`, etc.).
 - Code tool calls stream incremental chunks while LiteLLM emits `tool_calls`. When the MCP tool resolves, results are converted back into JSON events and appended to Mongo/disk storage.
 - The first chunk is a `ServerHint` carrying the `thread_id`; conversation variants are stored in-memory during streaming and flushed to MongoDB at the end, ensuring replay safety.
-- Clients can call `/api/chatbot/stop?thread_id=...` to move a conversation into `STOPPING`; the streaming loop exits and cancels in-flight MCP requests (code, rag, web-search) via the shared `ActiveRequest` registry.
+- Clients can call `POST /api/chatbot/stop` with `{"thread_id": "..."}` to move a conversation into `STOPPING`; the streaming loop exits and cancels in-flight MCP requests (code, rag, web-search) via the shared `ActiveRequest` registry.
 
 ## Persistence, Prompts, and Assets
 - **MongoDB (`mongodb_storage.py`)**: canonical record for threads. Each document stores `user_id`, `thread_id`, ISO timestamp, topic (summarized via LiteLLM), and serialized `StreamVariant` list.

src/climateclaw/api/chatbot/deletethread.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 from fastapi import APIRouter, Depends, HTTPException
+from pydantic import BaseModel
 
 from climateclaw.core.logging_setup import configure_logging
 from climateclaw.services.service_factory import (
@@ -14,9 +15,13 @@
 router = APIRouter()
 
 
-@router.get("/deletethread", dependencies=[AuthRequired])
+class DeleteThreadRequest(BaseModel):
+    thread_id: str
+
+
+@router.post("/deletethread", dependencies=[AuthRequired])
 async def delete_thread(
-    thread_id: str,
+    request: DeleteThreadRequest,
     auth: Authenticator = Depends(auth_dependency),
     storage: ThreadStorage = Depends(get_thread_storage),
 ):
@@ -47,6 +52,9 @@ async def delete_thread(
         HTTPException (500):
             - If deletion fails due to an internal storage error.
     """
+
+    thread_id = request.thread_id
+
     logger = configure_logging(__name__, thread_id=thread_id, user_id=auth.username)
 
     if not thread_id:

src/climateclaw/api/chatbot/editthread.py

@@ -1,4 +1,5 @@
 from fastapi import APIRouter, Depends, HTTPException
+from pydantic import BaseModel
 
 from climateclaw.core.logging_setup import configure_logging
 from climateclaw.services.service_factory import (
@@ -22,10 +23,14 @@
 router = APIRouter()
 
 
-@router.get("/editthread", dependencies=[AuthRequired])
+class EditThreadRequest(BaseModel):
+    source_thread_id: str
+    user_index: int
+
+
+@router.post("/editthread", dependencies=[AuthRequired])
 async def edit_thread(
-    source_thread_id: str,
-    user_index: int,
+    request: EditThreadRequest,
     auth: Authenticator = Depends(auth_dependency),
     storage: ThreadStorage = Depends(get_thread_storage),
 ):
@@ -80,6 +85,9 @@ async def edit_thread(
           `source_thread_id`. If deep branching is introduced, root tracking
           logic may require refinement.
     """
+
+    source_thread_id = request.source_thread_id
+    user_index = request.user_index
     user_name = auth.username
 
     if not source_thread_id:

src/climateclaw/api/chatbot/getthread.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
-from fastapi import APIRouter, Depends, HTTPException, Query
+from fastapi import APIRouter, Depends, HTTPException
+from pydantic import BaseModel
 
 from climateclaw.core.logging_setup import configure_logging
 from climateclaw.services.service_factory import (
@@ -22,6 +23,10 @@
 router = APIRouter()
 
 
+class GetThreadRequest(BaseModel):
+    thread_id: str | None = None
+
+
 def _post_process(variants: list[StreamVariant]) -> list[SVDict]:
     """Remove Prompt variants before returning, drop any StreamEnd except the final one, and drop 'unexpected manner' ones anywhere."""
     items = [item for item in variants if not is_prompt(item)]
@@ -35,9 +40,9 @@ def _post_process(variants: list[StreamVariant]) -> list[SVDict]:
     return cleaned
 
 
-@router.get("/getthread", dependencies=[AuthRequired])
+@router.post("/getthread", dependencies=[AuthRequired])
 async def get_thread(
-    thread_id: str | None = Query(None),
+    request: GetThreadRequest,
     auth: Authenticator = Depends(auth_dependency),
     storage: ThreadStorage = Depends(get_thread_storage),
 ):
@@ -73,6 +78,8 @@ async def get_thread(
             - If an error occurs while reading or processing the thread.
     """
 
+    thread_id = request.thread_id
+
     if not thread_id:
         raise HTTPException(
             status_code=422,

src/climateclaw/api/chatbot/getuserthreads.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 from fastapi import APIRouter, Depends, HTTPException
+from pydantic import BaseModel
 
 from climateclaw.core.logging_setup import configure_logging
 from climateclaw.services.service_factory import (
@@ -14,10 +15,14 @@
 router = APIRouter()
 
 
-@router.get("/getuserthreads", dependencies=[AuthRequired])
+class GetUserThreadsRequest(BaseModel):
+    num_threads: int = 20
+    page: int = 0
+
+
+@router.post("/getuserthreads", dependencies=[AuthRequired])
 async def get_user_threads(
-    num_threads: int = 20,
-    page: int = 0,
+    request: GetUserThreadsRequest,
     auth: Authenticator = Depends(auth_dependency),
     storage: ThreadStorage = Depends(get_thread_storage),
 ):
@@ -58,6 +63,9 @@ async def get_user_threads(
         HTTPException (500):
             - If fetching the user's thread history fails.
     """
+    num_threads = request.num_threads
+    page = request.page
+
     logger = configure_logging(__name__, user_id=auth.username)
 
     if not auth.username:

src/climateclaw/api/chatbot/searchthreads.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 from fastapi import APIRouter, Depends, HTTPException
+from pydantic import BaseModel
 
 from climateclaw.core.logging_setup import configure_logging
 from climateclaw.services.service_factory import (
@@ -14,11 +15,15 @@
 router = APIRouter()
 
 
-@router.get("/searchthreads", dependencies=[AuthRequired])
+class SearchThreadRequest(BaseModel):
+    query: str
+    page: int = 0
+    num_threads: int = 20
+
+
+@router.post("/searchthreads", dependencies=[AuthRequired])
 async def search_threads(
-    query: str,
-    page: int = 0,
-    num_threads: int = 20,
+    request: SearchThreadRequest,
     auth: Authenticator = Depends(auth_dependency),
     storage: ThreadStorage = Depends(get_thread_storage),
 ):
@@ -61,6 +66,11 @@ async def search_threads(
         HTTPException (500):
             - If querying threads fails due to an internal error.
     """
+
+    query = request.query
+    page = request.page
+    num_threads = request.num_threads
+
     logger = configure_logging(__name__, user_id=auth.username)
 
     if not auth.username:

src/climateclaw/api/chatbot/setthreadtopic.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
 from fastapi import APIRouter, Depends, HTTPException
+from pydantic import BaseModel
 
 from climateclaw.core.logging_setup import configure_logging
 from climateclaw.services.service_factory import (
@@ -14,10 +15,14 @@
 router = APIRouter()
 
 
-@router.get("/setthreadtopic", dependencies=[AuthRequired])
+class SetThreadTopicRequest(BaseModel):
+    thread_id: str
+    topic: str
+
+
+@router.post("/setthreadtopic", dependencies=[AuthRequired])
 async def set_thread_topic(
-    thread_id: str,
-    topic: str,
+    request: SetThreadTopicRequest,
     auth: Authenticator = Depends(auth_dependency),
     storage: ThreadStorage = Depends(get_thread_storage),
 ):
@@ -51,6 +56,10 @@ async def set_thread_topic(
         HTTPException (500):
             - If updating the thread topic fails due to an internal error.
     """
+
+    thread_id = request.thread_id
+    topic = request.topic
+
     if not thread_id:
         raise HTTPException(
             status_code=422,

src/climateclaw/api/chatbot/stop.py

@@ -1,4 +1,5 @@
-from fastapi import APIRouter, HTTPException, Query
+from fastapi import APIRouter, HTTPException
+from pydantic import BaseModel
 from starlette.status import HTTP_422_UNPROCESSABLE_CONTENT
 
 from climateclaw.core.logging_setup import configure_logging
@@ -8,11 +9,13 @@
 router = APIRouter()
 
 
-@router.get("/stop", dependencies=[AuthRequired])
-async def stop_get(
-    thread_id: str | None = Query(
-        default=None, description="Thread to stop (optional)"
-    ),
+class StopRequest(BaseModel):
+    thread_id: str | None = None
+
+
+@router.post("/stop", dependencies=[AuthRequired])
+async def stop(
+    request: StopRequest,
 ):
     """
     Stop Active Conversation Streaming.
@@ -24,7 +27,7 @@ async def stop_get(
     Parameters:
         thread_id (str | None):
             The unique identifier of the thread whose streaming process
-            should be stopped. Must be provided as a query parameter.
+            should be stopped. Must be provided in the request body.
 
     Returns:
         dict:
@@ -39,11 +42,12 @@ async def stop_get(
         HTTPException (500):
             - Failure to request stop.
     """
+    thread_id = request.thread_id
 
     if not thread_id:
         raise HTTPException(
             status_code=HTTP_422_UNPROCESSABLE_CONTENT,
-            detail="Thread ID is missing. Please provide a thread_id in the query parameters.",
+            detail="Thread ID is missing. Please provide a thread_id in the request body.",
         )
 
     logger = configure_logging(__name__, thread_id=thread_id)
@@ -53,14 +57,15 @@ async def stop_get(
         if ok:
             logger.debug("Initiated stop request", extra={"thread_id": thread_id})
             return {"detail": "Conversation stopped."}
-        else:
-            logger.exception(
-                f"Thread not found in the registry. Nothing to stop: {thread_id}"
-            )
-            raise HTTPException(
-                status_code=404,
-                detail=f"Conversation with given thread-id not found in the registry: {thread_id}",
-            )
+        logger.warning(
+            f"Thread not found in the registry. Nothing to stop: {thread_id}"
+        )
+        raise HTTPException(
+            status_code=404,
+            detail=f"Conversation with given thread-id not found in the registry: {thread_id}",
+        )
+    except HTTPException:
+        raise
     except Exception as e:
         logger.exception(f"Failed to stop the thread {thread_id}: {e}")
         raise HTTPException(

src/climateclaw/api/chatbot/streamresponse.py

@@ -4,7 +4,8 @@
 import time
 from collections.abc import Generator
 
-from fastapi import APIRouter, Depends, HTTPException, Query
+from fastapi import APIRouter, Depends, HTTPException
+from pydantic import BaseModel
 from starlette.responses import StreamingResponse
 
 from climateclaw.core.available_chatbots import (
@@ -49,6 +50,13 @@
 CHECK_INTERVAL = 3  # seconds, the interval to wait before check STOP request
 
 
+class StreamResponseRequest(BaseModel):
+    thread_id: str | None = None
+    input: str | None = None
+    chatbot: str | None = None
+    store_thread: bool = True
+
+
 def _sse_data(obj: SVDict) -> Generator[bytes]:
     if obj.get("variant") == IMAGE:
         image_b64 = obj.get("content")
@@ -64,12 +72,9 @@ def _sse_data(obj: SVDict) -> Generator[bytes]:
         yield f"{payload}\n".encode()
 
 
-@router.get("/streamresponse", dependencies=[AuthRequired])
+@router.post("/streamresponse", dependencies=[AuthRequired])
 async def streamresponse(
-    thread_id: str | None = Query(None),
-    input: str | None = Query(None),
-    chatbot: str | None = Query(None),
-    store_thread: bool = True,
+    request: StreamResponseRequest,
     auth: Authenticator = Depends(auth_dependency),
     storage: ThreadStorage = Depends(get_thread_storage),
 ):
@@ -124,6 +129,12 @@ async def streamresponse(
             - If stream preparation fails or an internal server error occurs
               before streaming begins.
     """
+
+    thread_id = request.thread_id
+    input = request.input
+    chatbot = request.chatbot
+    store_thread = request.store_thread
+
     logger = configure_logging(__name__)
 
     if not thread_id: