fix: missing label for "extra-label" error (#1772)

- fixes #1771

Author: pierrecamilleri

frictionless/resource/__spec__/test_validate_schema.py

@@ -38,6 +38,7 @@ def test_resource_validate_invalid_resource():
 
 def test_resource_validate_schema_extra_headers_and_cells():
     schema = Schema.from_descriptor({"fields": [{"name": "id", "type": "integer"}]})
+    # resource with extra label "name"
     resource = TableResource(path="data/table.csv", schema=schema)
     report = resource.validate()
     assert report.flatten(["rowNumber", "fieldNumber", "type"]) == [
@@ -46,6 +47,10 @@ def test_resource_validate_schema_extra_headers_and_cells():
         [3, 2, "extra-cell"],
     ]
 
+    extra_label_error = report.task.errors[0]
+    assert extra_label_error.label == "name"
+    assert '"name"' in extra_label_error.message
+
 
 def test_resource_validate_schema_multiple_errors():
     source = "data/schema-errors.csv"

frictionless/table/header.py

@@ -179,13 +179,9 @@ def _get_missing_fields(self) -> List[Tuple[int, Field]]:
 
             def required_and_missing(field: Field) -> bool:
                 required = field.required or (
-                    field.schema is not None
-                    and field.name in field.schema.primary_key
-                )
-                return (
-                    required
-                    and self.__normalize(field.name) not in normalized_labels
+                    field.schema is not None and field.name in field.schema.primary_key
                 )
+                return required and self.__normalize(field.name) not in normalized_labels
 
             missing = [field for field in fields if required_and_missing(field)]
 
@@ -236,7 +232,7 @@ def __process(self):
                     note="",
                     labels=list(map(str, labels)),
                     row_numbers=self.__row_numbers,
-                    label="",
+                    label=label,
                     field_name="",
                     field_number=extra_start + offset,
                 )