Skip to content

Commit 639e164

Browse files
authored
Merge pull request #188 from frictionlessdata/tabular-data-package
Don't set `"profile"="tabular-data-package"` and remove it from example dataset
2 parents 07508c2 + aa49d40 commit 639e164

6 files changed

Lines changed: 1 addition & 16 deletions

File tree

R/create_package.R

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
#' - [`resources`](
99
#' https://specs.frictionlessdata.io/data-package/#required-properties) (an
1010
#' empty list) if not present.
11-
#' - [`profile`](https://specs.frictionlessdata.io/data-package/#profile) (set
12-
#' to `"tabular-data-package"`) if not present.
1311
#' - `directory` (set to `"."` for the current directory) if not present.
1412
#' It is used as the base path to access resources with [read_resource()].
1513
#'
@@ -33,7 +31,6 @@ create_package <- function(descriptor = NULL) {
3331
}
3432

3533
# Add properties
36-
descriptor$profile <- replace_null(descriptor$profile, "tabular-data-package")
3734
descriptor$resources <- replace_null(descriptor$resources, list())
3835
descriptor$directory <- replace_null(descriptor$directory, ".") # Current dir
3936

data/example_package.rda

-3 Bytes
Binary file not shown.

inst/extdata/datapackage.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"name": "example_package",
33
"id": "115f49c1-8603-463e-a908-68de98327266",
44
"created": "2021-03-02T17:22:33Z",
5-
"profile": "tabular-data-package",
65
"licenses": [
76
{
87
"name": "CC0-1.0",

man/create_package.Rd

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/example_package.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/test-create_package.R

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,6 @@ test_that("create_package() returns error on invalid descriptor", {
1313
)
1414
})
1515

16-
test_that("create_package() sets profile to 'tabular-data-package' if not
17-
provided", {
18-
new <- create_package()
19-
expect_identical(new$profile, "tabular-data-package")
20-
21-
existing <- create_package(list(profile = "not_default"))
22-
expect_identical(existing$profile, "not_default")
23-
})
24-
2516
test_that("create_package() sets resources if not provided", {
2617
new <- create_package()
2718
expect_identical(new$resources, list())

0 commit comments

Comments
 (0)