Only explicitly enable developer mode

Remove check for the `CI` environment variable when declaring the
developer mode option to avoid enabling it when the project is built on
a CI server from source by 3rd parties.

Author: friendlyanon

cmake-init/templates/common/CMakePresets.json

@@ -6,6 +6,13 @@
     "patch": 0
   },
   "configurePresets": [
+    {
+      "name": "dev-mode",
+      "hidden": true,
+      "cacheVariables": {
+        "%(name)s_DEVELOPER_MODE": "ON"
+      }
+    },
     {
       "name": "cppcheck",
       "hidden": true,
@@ -58,7 +65,7 @@
     },
     {
       "name": "ci-coverage",
-      "inherits": "ci-unix",
+      "inherits": ["ci-unix", "dev-mode"],
       "cacheVariables": {
         "CMAKE_BUILD_TYPE": "Coverage",
         "CMAKE_CXX_FLAGS_COVERAGE": "-O0 -g --coverage -fkeep-inline-functions -fkeep-static-functions",
@@ -68,23 +75,23 @@
     },
     {
       "name": "ci-sanitizer",
-      "inherits": "ci-unix",
+      "inherits": ["ci-unix", "dev-mode"],
       "cacheVariables": {
         "CMAKE_BUILD_TYPE": "Sanitizer",
         "CMAKE_CXX_FLAGS_SANITIZER": "-O2 -g -fsanitize=$env{SANITIZER} -fno-omit-frame-pointer $env{EXTRA_FLAGS}"
       }
     },
     {
       "name": "ci-macos",
-      "inherits": "ci-unix"
+      "inherits": ["ci-unix", "dev-mode"]
     },
     {
       "name": "ci-ubuntu",
-      "inherits": ["ci-unix", "clang-tidy", "cppcheck"]
+      "inherits": ["ci-unix", "clang-tidy", "cppcheck", "dev-mode"]
     },
     {
       "name": "ci-windows",
-      "inherits": "ci-win64"
+      "inherits": ["ci-win64", "dev-mode"]
     }
   ]
 }

cmake-init/templates/common/CMakeUserPresets.json

@@ -8,9 +8,8 @@
   "configurePresets": [
     {
       "name": "dev",
-      "inherits": ["ci-%(os)s"{if use_clang_tidy}, "clang-tidy"{end}{if use_cppcheck}, "cppcheck"{end}],
+      "inherits": ["dev-mode", "ci-%(os)s"{if use_clang_tidy}, "clang-tidy"{end}{if use_cppcheck}, "cppcheck"{end}],
       "cacheVariables": {
-        "%(name)s_DEVELOPER_MODE": "ON",
         "BUILD_DOCUMENTATION": "ON"
       }
     }

cmake-init/templates/common/HACKING.md

@@ -14,9 +14,7 @@ option makes tests and other developer targets and options available. Not
 enabling this option means that you are a consumer of this project and thus you
 have no need for these targets and options.
 
-Developer mode is forced to be on when the `CI` environment variable is set to
-a value that CMake recognizes as "on", which is set to `true` in all of the CI
-workflows.
+Developer mode is always set to on in CI workflows.
 
 ### Presets
 
@@ -42,10 +40,7 @@ the project:
   "configurePresets": [
     {
       "name": "dev",
-      "inherits": ["ci-<os>"],
-      "cacheVariables": {
-        "%(name)s_DEVELOPER_MODE": "ON"
-      }
+      "inherits": ["dev-mode", "ci-<os>"]
     }
   ]
 }

cmake-init/templates/common/cmake/variables.cmake

@@ -5,11 +5,8 @@
 # Targets necessary to build the project must be provided unconditionally, so
 # consumers can trivially build and package the project
 if(PROJECT_IS_TOP_LEVEL)
-  option(%(name)s_DEVELOPER_MODE "Enable developer mode" OFF)
-{type shared}  option(BUILD_SHARED_LIBS "Build shared libs." OFF){end}
-  if("$ENV{CI}")
-    set(%(name)s_DEVELOPER_MODE ON CACHE INTERNAL "")
-  endif()
+  option(%(name)s_DEVELOPER_MODE "Enable developer mode" OFF){type shared}
+  option(BUILD_SHARED_LIBS "Build shared libs." OFF){end}
 endif()
 
 {type shared}# ---- Suppress C4251 on Windows ----