Ensure proper this context in lifecycle callback defined at the time of instantiation (#383)

Author: viacheslaff

packages/frint/src/App.spec.js

@@ -511,4 +511,35 @@ describe('frint  › App', function () {
     const app = new Root();
     expect(app.get('foo')).to.equal('original foo [updated]');
   });
+
+  it('can access and update providers from lifecycle callback defined while instantiating', function () {
+    const Root = createApp({
+      name: 'RootApp',
+      providers: [
+        {
+          name: 'foo',
+          useValue: 'original foo',
+        },
+      ],
+      initialize() {
+        const foo = this.get('foo');
+        this.container.register({
+          name: 'foo',
+          useValue: `${foo} [updatedFromCreateApp]`,
+        });
+      }
+    });
+
+    const app = new Root({
+      initialize() {
+        const foo = this.get('foo');
+        this.container.register({
+          name: 'foo',
+          useValue: `${foo} [updatedFromInstantiation]`,
+        });
+      }
+    });
+
+    expect(app.get('foo')).to.equal('original foo [updatedFromCreateApp] [updatedFromInstantiation]');
+  });
 });

packages/frint/src/createApp.js

@@ -16,8 +16,8 @@ function mergeOptions(createAppOptions, constructorOptions) {
       typeof constructorOptions[cbName] === 'function'
     ) {
       mergedOptions[cbName] = function lifecycleCb() {
-        createAppOptions[cbName]();
-        constructorOptions[cbName]();
+        createAppOptions[cbName].call(this);
+        constructorOptions[cbName].call(this);
       };
     }
   });