Skip to content

Consider creating an ember-modifier class #109

@Panman82

Description

@Panman82

The <FroalaEditor /> component largely depends on interaction with the attached element to initialize the Froala Editor. Technically ember now allows this access by using a modifier. Most of the <FroalaEditor /> code could be moved to a modifier class definition. However, there are some downsides that the component version guards against (mainly ensuring @content is passed in and not used as block content <FroalaEditor>{{this.content}}</FroalaEditor>). Currently this addon uses ember-render-modifiers to gain access to the element. At minimum, I would say both (component and modifier) would be provided by the addon if we do move to a modifier. An alternate and more custom solution is to create a custom modifier manager too, to avoid a dependency on ember-modifier.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions