Bibtex Writer: cannot create both issn and isbn for a book

[coliin8]

I am generating commonmeta json directly, as using commonmeta-py to generate metadata formats for new books.

I think I understand I can only have a single container object in commonmeta json, with one identifier and type.

This means if you provide a BookSeries in container you cannot provide both isbn for the book and issn for series.

So generating bibtex:

metadata = Metadata(boook_data, via="commonmeta") return metadata.write(to="bibtex")

code in write_bibtex_item is:

issn = ( container.get("identifier", None) if container.get("identifierType", None) == "ISSN" else None ) isbn = ( container.get("identifier", None) if container.get("identifierType", None) == "ISBN" else None )

so generated bibtex will never provide both together:

ISBN = {978-1-911712-56-5}, ISSN = {2996-5241},

Is it possible to consider the idea of multiple identifiers in the container - though I am not sure how that would effect other writers?

[coliin8]

Also Crossref_xml writer fails without the container -> identifierType = ISBN. It generates an XML Schema validation within the metadata.write_errors.

Container objects I am submitting:

{ "id": "10.31389/lsepress.ame", "type": "Book", "date": {"published": "2021-10-11"}, "identifiers": [], "publisher": {"name": "LSE Press"}, "titles": [{"title": "Advanced Macroeconomics"}], "url": "https://testpress.example.com/books/1", "container": { "type": "BookSeries", "title": "Karlsruher Schriftenreihe Fahrzeugsystemtechnik", "identifierType": "ISSN", "identifier": "1869-6058", "description": "ISSN 1869-6058", }, ... }

Basic code:
metadata = Metadata(boook_data, via="commonmeta") return metadata.write(to="crossref_xml")

Errors raised:

`failed validating <Element '{http://www.crossref.org/schema/5.4.0}book_metadata' at 0x11b169620> with XsdGroup(model='sequence', occurs=[1, 1]):

Reason: Unexpected child with tag '{http://www.crossref.org/schema/5.4.0}publisher' at position 5. Tag ('{http://www.crossref.org/schema/5.4.0}isbn' | '{http://www.crossref.org/schema/5.4.0}noisbn') expected.

Schema component:

<xsd:complexType xmlns:xsd="http://www.w3.org/2001/XMLSchema">
xsd:sequence
<xsd:element ref="contributors" minOccurs="0" />
<xsd:element ref="titles" />
<xsd:element ref="jats:abstract" minOccurs="0" maxOccurs="unbounded" />
<xsd:element ref="edition_number" minOccurs="0" />
<xsd:element ref="publication_date" maxOccurs="10" />
<xsd:element ref="acceptance_date" minOccurs="0" maxOccurs="1" />
xsd:choice
<xsd:element ref="isbn" maxOccurs="100" />
<xsd:element ref="noisbn" />
</xsd:choice>
<xsd:element ref="publisher" minOccurs="1" maxOccurs="unbounded" />
<xsd:element ref="publisher_item" minOccurs="0" />
xsd:choice
<xsd:element ref="crossmark" minOccurs="0" />
xsd:sequence
<xsd:element ref="fr:program" minOccurs="0" maxOccurs="1" />
<xsd:element ref="ai:program" minOccurs="0" maxOccurs="1" />
</xsd:sequence>
...
...
</xsd:complexType>

Instance type: <class 'xml.etree.ElementTree.Element'>

Instance:

<book_metadata xmlns="http://www.crossref.org/schema/5.4.0" xmlns:ai="http://www.crossref.org/AccessIndicators.xsd" xmlns:jats="http://www.ncbi.nlm.nih.gov/JATS1">

<person_name contributor_role="author" sequence="first">
<given_name>Filipe</given_name>
Campante
</person_name>
<person_name contributor_role="author" sequence="additional">
<given_name>Federico</given_name>
Sturzenegger
</person_name>
<person_name contributor_role="author" sequence="additional">
<given_name>Andrés</given_name>
Velasco
</person_name>


<title>Advanced Macroeconomics</title>

jats:abstract
jats:pThis is a test description.</jats:p>
...
...
</book_metadata>

Path: /doi_batch/body/book/book_metadata`