NoAsyncRunSynchronouslyInLibrary: ignore obsolete

Methods and functions when applying the rule.

Added 2 more tests.

Marked non-async parsing methods re-introduced in previous
commit with `[<Obsolete>]` attribute.

Author: webwarrior-ws

src/FSharpLint.Core/Application/Lint.fs

@@ -510,6 +510,7 @@ module Lint =
             return FailedToLoadFile projectFilePath |> LintResult.Failure
     }
 
+    [<Obsolete "Use asyncLintProject instead, otherwise this synchronous version might cause thread blocking issues; this API will be removed in the future.">]
     let lintProject optionalParams projectFilePath toolsPath =
         asyncLintProject optionalParams projectFilePath toolsPath |> Async.RunSynchronously
 
@@ -569,6 +570,7 @@ module Lint =
             return FailedToLoadFile solutionFilePath |> LintResult.Failure
     }
 
+    [<Obsolete "Use asyncLintSolution instead, otherwise this synchronous version might cause thread blocking issues; this API will be removed in the future.">]
     let lintSolution optionalParams solutionFilePath toolsPath =
         asyncLintSolution optionalParams solutionFilePath toolsPath |> Async.RunSynchronously
 
@@ -618,6 +620,7 @@ module Lint =
             | ParseFile.Failed failure -> return LintResult.Failure(FailedToParseFile failure)
         }
 
+    [<Obsolete "Use asyncLintSource instead, otherwise this synchronous version might cause thread blocking issues; this API will be removed in the future.">]
     let lintSource optionalParams source =
         asyncLintSource optionalParams source |> Async.RunSynchronously
 
@@ -669,6 +672,7 @@ module Lint =
             return FailedToLoadFile filePath |> LintResult.Failure
     }
 
+    [<Obsolete "Use asyncLintFile instead, otherwise this synchronous version might cause thread blocking issues; this API will be removed in the future.">]
     let lintFile optionalParams filePath =
         asyncLintFile optionalParams filePath |> Async.RunSynchronously
 
@@ -714,5 +718,6 @@ module Lint =
             return LintResult.Failure (RunTimeConfigError err)
     }
 
+    [<Obsolete "Use asyncLintFiles instead, otherwise this synchronous version might cause thread blocking issues; this API will be removed in the future.">]
     let lintFiles optionalParams filePaths =
         asyncLintFiles optionalParams filePaths |> Async.RunSynchronously

src/FSharpLint.Core/Rules/Conventions/NoAsyncRunSynchronouslyInLibrary.fs

@@ -77,15 +77,32 @@ let isInTheSameModuleAsTest (nodes: array<AbstractSyntaxArray.Node>) (maybeProje
     | None ->
         nodes |> Array.exists (fun node -> isTestMethodOrClass node.Actual)
 
+let isInObsoleteMethodOrFunction parents =
+    let isObsolete node =
+        match node with
+        | AstNode.MemberDefinition(SynMemberDefn.Member(SynBinding(_, _, _, _, attributes, _, _, _, _, _, _, _, _), _)) ->
+            attributes 
+            |> extractAttributeNames
+            |> Seq.contains "Obsolete"
+        | AstNode.Binding(SynBinding(_, _, _, _, attributes, _, _, _, _, _, _, _, _)) ->
+            attributes 
+            |> extractAttributeNames
+            |> Seq.contains "Obsolete"
+        | _ -> false
+
+    parents |> List.exists isObsolete
+
 let checkIfInLibrary (args: AstNodeRuleParams) (range: range) : array<WarningDetails> =
     let ruleNotApplicable =
         match args.CheckInfo with
         | Some checkFileResults ->
             hasEntryPoint checkFileResults args.ProjectCheckInfo
             || isInTestProject checkFileResults
+            || isInObsoleteMethodOrFunction (args.GetParents args.NodeIndex)
             || isInTheSameModuleAsTest args.SyntaxArray args.ProjectCheckInfo
         | None ->
-            isInTheSameModuleAsTest args.SyntaxArray args.ProjectCheckInfo
+            isInObsoleteMethodOrFunction (args.GetParents args.NodeIndex)
+            || isInTheSameModuleAsTest args.SyntaxArray args.ProjectCheckInfo
 
     if ruleNotApplicable then
         Array.empty

tests/FSharpLint.Core.Tests/Rules/Conventions/NoAsyncRunSynchronouslyInLibrary.fs

@@ -101,3 +101,32 @@ type FooTest () =
         ()""")
 
         this.AssertNoWarnings()
+
+    [<Test>]
+    member this.``Async.RunSynchronously may be used in methods with Obsolete attribute``() =
+        this.Parse("""
+module Program
+
+type FooTest () =
+    [<Obsolete>]
+    member this.Foo() =
+        async {
+            return ()
+        }
+        |> Async.RunSynchronously""")
+
+        this.AssertNoWarnings()
+
+    [<Test>]
+    member this.``Async.RunSynchronously may be used in functions with Obsolete attribute``() =
+        this.Parse("""
+module Program
+
+[<Obsolete>]
+let Foo() =
+    async {
+        return ()
+    }
+    |> Async.RunSynchronously""")
+
+        this.AssertNoWarnings()