From 89d91444268535944dba2ea3fb95200388d586e8 Mon Sep 17 00:00:00 2001 From: Jeremiah Dodds Date: Sun, 1 Mar 2020 23:59:31 -0500 Subject: [PATCH] these lines, specifically the {x|y}.Depth checks seem to be triggering stack overflows --- src/Paket.Core/Versioning/Requirements.fs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Paket.Core/Versioning/Requirements.fs b/src/Paket.Core/Versioning/Requirements.fs index 16b4bad9f8..b0fe7bc57c 100644 --- a/src/Paket.Core/Versioning/Requirements.fs +++ b/src/Paket.Core/Versioning/Requirements.fs @@ -1226,10 +1226,10 @@ type PackageRequirement = static member Compare(x,y,startWithPackage:PackageFilter option,boostX,boostY) = if obj.ReferenceEquals(x, y) then 0 else - let c = compare - (not x.VersionRequirement.Range.IsGlobalOverride,x.Depth) - (not y.VersionRequirement.Range.IsGlobalOverride,y.Depth) - if c <> 0 then c else +// let c = compare +// (not x.VersionRequirement.Range.IsGlobalOverride,x.Depth) +// (not y.VersionRequirement.Range.IsGlobalOverride,y.Depth) +// if c <> 0 then c else let c = match startWithPackage with | Some filter when filter.Match x.Name -> -1 | Some filter when filter.Match y.Name -> 1