Table names are not quted in generated SQL in Development_V1 branch

[zhengbli]

I got the following SQL

SELECT [x_11].[Id] as 'Id',[x_11].[Name] as 'Name',[x_11].[Email] as 'Email',[x_11].[Pwd] as 'Pwd',[x_11].[ProfileImage] as 'ProfileImage' 
FROM dbo.User as [x_11] 

From

query {
    for u in ctx.Dbo.User do select u
}

And that gave me an error because the User is a keyword in sql server.

I think it should generate [dbo].[User] instead of dbo.User

[pezipink]

Did this work in the other branch? @colinbull do you know what happened to this?

[zhengbli]

This worked for me when I used master

[pezipink]

Ok, sorry about that, I did not think we had changed anything relating to the actual sql gen! Will try and look at this soon

[colinbull]

Hum nor was I I'll have a look at this tonight.

Sent from my iPhone

On 26 Nov 2015, at 19:25, Ross McKinlay notifications@github.com wrote:

Ok, sorry about that, I did not think we had changed anything relating to the actual sql gen! Will try and look at this soon

—
Reply to this email directly or view it on GitHub.

[colinbull]

@zhengbli @pezipink can you give this a test I don't have a SQL server instance to hand at the moment.

[zhengbli]

Sure I'll try it in a moment

[zhengbli]

The commit fixed the problem for me. Thanks!

[colinbull]

Closing..