|
| 1 | +//===----------------------------------------------------------------------===// |
| 2 | +// Copyright © 2026 Apple Inc. and the container project authors. |
| 3 | +// |
| 4 | +// Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | +// you may not use this file except in compliance with the License. |
| 6 | +// You may obtain a copy of the License at |
| 7 | +// |
| 8 | +// https://www.apache.org/licenses/LICENSE-2.0 |
| 9 | +// |
| 10 | +// Unless required by applicable law or agreed to in writing, software |
| 11 | +// distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | +// See the License for the specific language governing permissions and |
| 14 | +// limitations under the License. |
| 15 | +//===----------------------------------------------------------------------===// |
| 16 | + |
| 17 | +import Foundation |
| 18 | +import Testing |
| 19 | +import TOML |
| 20 | + |
| 21 | +@testable import ContainerPersistence |
| 22 | + |
| 23 | +/// Tests for the default `dns.domain` baked into `ContainerSystemConfig.DNSConfig` |
| 24 | +/// as part of the CHAOS-1478 routing fix. |
| 25 | +/// |
| 26 | +/// The default value (`"test"`) MUST stay in sync with the resolver file written |
| 27 | +/// by `scripts/pkg-scripts/postinstall` (`/etc/resolver/containerization.test`). |
| 28 | +/// If you change the default here, also update the postinstall script. |
| 29 | +struct ContainerSystemConfigDNSDefaultTests { |
| 30 | + // MARK: - Default value |
| 31 | + |
| 32 | + /// `DNSConfig()` (no arguments) yields the default domain. This is the |
| 33 | + /// path used when `ContainerSystemConfig` is constructed without a TOML |
| 34 | + /// file (e.g. fresh install, no user config). |
| 35 | + @Test func testDefaultDomainIsTest() { |
| 36 | + let config = DNSConfig() |
| 37 | + #expect(config.domain == "test") |
| 38 | + #expect(config.domain == DNSConfig.defaultDomain) |
| 39 | + } |
| 40 | + |
| 41 | + /// Explicit `nil` is preserved — caller can intentionally clear the domain. |
| 42 | + /// This is needed for tests and for advanced configurations where the |
| 43 | + /// caller wants to skip search-domain injection entirely. |
| 44 | + @Test func testExplicitNilIsPreserved() { |
| 45 | + let config = DNSConfig(domain: nil) |
| 46 | + #expect(config.domain == nil) |
| 47 | + } |
| 48 | + |
| 49 | + /// Explicit non-default domain is preserved. |
| 50 | + @Test func testExplicitDomainIsPreserved() { |
| 51 | + let config = DNSConfig(domain: "example.com") |
| 52 | + #expect(config.domain == "example.com") |
| 53 | + } |
| 54 | + |
| 55 | + // MARK: - TOML decode |
| 56 | + |
| 57 | + /// TOML with no `[dns]` section at all → top-level config has the default. |
| 58 | + /// This is the most common case: a user with a minimal runtime-config.toml. |
| 59 | + @Test func testTOMLDecodeMissingDnsSectionUsesDefault() throws { |
| 60 | + let toml = "" |
| 61 | + let decoded = try TOMLDecoder().decode(ContainerSystemConfig.self, from: Data(toml.utf8)) |
| 62 | + #expect(decoded.dns.domain == "test") |
| 63 | + } |
| 64 | + |
| 65 | + /// TOML with `[dns]` but no `domain` key → defaults to `"test"`. |
| 66 | + @Test func testTOMLDecodeEmptyDnsSectionUsesDefault() throws { |
| 67 | + let toml = """ |
| 68 | + [dns] |
| 69 | + """ |
| 70 | + let decoded = try TOMLDecoder().decode(ContainerSystemConfig.self, from: Data(toml.utf8)) |
| 71 | + #expect(decoded.dns.domain == "test") |
| 72 | + } |
| 73 | + |
| 74 | + /// TOML with explicit `dns.domain = "foo"` → user override takes effect. |
| 75 | + /// This guards the "user can opt out / replace" pathway. |
| 76 | + @Test func testTOMLDecodeExplicitDomainOverridesDefault() throws { |
| 77 | + let toml = """ |
| 78 | + [dns] |
| 79 | + domain = "internal.example" |
| 80 | + """ |
| 81 | + let decoded = try TOMLDecoder().decode(ContainerSystemConfig.self, from: Data(toml.utf8)) |
| 82 | + #expect(decoded.dns.domain == "internal.example") |
| 83 | + } |
| 84 | + |
| 85 | + /// TOML with explicit empty-string domain → preserved as empty string. |
| 86 | + /// Empty string is treated as "no domain" by the search-domain injection |
| 87 | + /// logic in `Utility.containerConfigFromFlags`. Decoding must NOT silently |
| 88 | + /// substitute the default in this case — the user explicitly opted out. |
| 89 | + @Test func testTOMLDecodeExplicitEmptyStringDomainIsPreserved() throws { |
| 90 | + let toml = """ |
| 91 | + [dns] |
| 92 | + domain = "" |
| 93 | + """ |
| 94 | + let decoded = try TOMLDecoder().decode(ContainerSystemConfig.self, from: Data(toml.utf8)) |
| 95 | + #expect(decoded.dns.domain == "") |
| 96 | + } |
| 97 | + |
| 98 | + // MARK: - Top-level ContainerSystemConfig wiring |
| 99 | + |
| 100 | + /// `ContainerSystemConfig()` with all defaults exposes the DNS default at |
| 101 | + /// the top level — verifies the construction chain doesn't drop it. |
| 102 | + @Test func testTopLevelDefaultExposesDNSDefault() { |
| 103 | + let config = ContainerSystemConfig() |
| 104 | + #expect(config.dns.domain == "test") |
| 105 | + } |
| 106 | +} |
0 commit comments