Merge pull request #7 from inextensodigital/fix-deployment-status-state-validation

vibou · web-flow · commit 1a752c7e8aa3 · 2019-08-21T18:39:20.000+02:00
fix: add success as a valid deployment status value
diff --git a/cmd/deployment_status.go b/cmd/deployment_status.go
@@ -88,6 +88,7 @@ var deploymentStatusGetCmd = &cobra.Command{
 func isValidState(state string) error {
 	switch state {
 	case
+		"success",
 		"error",
 		"failure",
 		"inactive",
@@ -97,7 +98,7 @@ func isValidState(state string) error {
 		return nil
 	}
 
-	return errors.New("invalid state: should be one of error, failure, inactive, in_progress, queued or pending")
+	return errors.New("invalid state: should be one of success, error, failure, inactive, in_progress, queued or pending")
 }
 
 var deploymentStatusCreateCmd = &cobra.Command{

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,7 @@ var deploymentStatusGetCmd = &cobra.Command{`
`88`	`88`	`func isValidState(state string) error {`
`89`	`89`	`switch state {`
`90`	`90`	`case`
	`91`	`+ "success",`
`91`	`92`	`"error",`
`92`	`93`	`"failure",`
`93`	`94`	`"inactive",`
`@@ -97,7 +98,7 @@ func isValidState(state string) error {`
`97`	`98`	`return nil`
`98`	`99`	`}`
`99`	`100`
`100`		`- return errors.New("invalid state: should be one of error, failure, inactive, in_progress, queued or pending")`
	`101`	`+ return errors.New("invalid state: should be one of success, error, failure, inactive, in_progress, queued or pending")`
`101`	`102`	`}`
`102`	`103`
`103`	`104`	`var deploymentStatusCreateCmd = &cobra.Command{`